Improve CodeRegionTable build time by 30x

runtime/vm/isolate.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/isolate.h"
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "platform/json.h"
 #include "lib/mirrors.h"
@@ skipping 461 matching lines @@
 void Isolate::SetStackLimit(uword limit) {
   MutexLocker ml(mutex_);
   if (stack_limit_ == saved_stack_limit_) {
     // No interrupt pending, set stack_limit_ too.
     stack_limit_ = limit;
   }
   saved_stack_limit_ = limit;
 }
 
 
-bool Isolate::GetStackBounds(uintptr_t* lower, uintptr_t* upper) {
-  uintptr_t stack_lower = stack_limit();
-  if (stack_lower == static_cast<uintptr_t>(~0)) {
+bool Isolate::GetStackBounds(uword* lower, uword* upper) {
+  uword stack_lower = stack_limit();
+  if (stack_lower == static_cast<uword>(~0)) {

[siva, 2014/02/19 18:09:54]

should this be
if (stack_lower == kUwordMax) {
  ....
}

[Cutch, 2014/02/19 18:20:31]

Done.

     stack_lower = saved_stack_limit();
   }
-  if (stack_lower == static_cast<uintptr_t>(~0)) {
+  if (stack_lower == static_cast<uword>(~0)) {

[siva, 2014/02/19 18:09:54]

Ditto...

[Cutch, 2014/02/19 18:20:31]

Done.

     return false;
   }
-  uintptr_t stack_upper = stack_lower + GetSpecifiedStackSize();
+  uword stack_upper = stack_lower + GetSpecifiedStackSize();
   *lower = stack_lower;
   *upper = stack_upper;
   return true;
 }
 
 
 void Isolate::ScheduleInterrupts(uword interrupt_bits) {
   // TODO(turnidge): Can't use MutexLocker here because MutexLocker is
   // a StackResource, which requires a current isolate.  Should
   // MutexLocker really be a StackResource?
@@ skipping 550 matching lines @@
   return func.raw();
 }
 
 
 void IsolateSpawnState::Cleanup() {
   SwitchIsolateScope switch_scope(isolate());
   Dart::ShutdownIsolate();
 }
 
 }  // namespace dart