Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1511413003: Experiment: retire Oilpan disposal of persisted plugin widgets. (Closed)

Created:
5 years ago by sof
Modified:
5 years ago
Reviewers:
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, blink-reviews-api_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Experiment: retire Oilpan disposal of persisted plugin widgets. Replaced by prefinalizing of WebPluginContainerImpl. R= BUG=

Patch Set 1 #

Patch Set 2 : more removal of disposes #

Patch Set 3 : always dispose WebPluginContainerImpls #

Patch Set 4 : scale back explicit disposal to where wanted/needed.. #

Patch Set 5 : remove shouldDisposePlugin vestiges #

Patch Set 6 : remove plugin element registration over LocalFrames #

Patch Set 7 : reinstate dispose on replacing persisted widget #

Patch Set 8 : ..and hiding #

Patch Set 9 : rebased #

Patch Set 10 : more disposal removed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -179 lines) Patch
M third_party/WebKit/Source/build/features.gypi View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/config.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.h View 1 2 3 4 5 6 7 8 9 2 chunks +0 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 1 2 3 4 5 6 7 8 9 3 chunks +0 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLPlugInElement.h View 1 2 3 4 5 6 7 8 9 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp View 1 2 3 4 5 6 7 8 9 3 chunks +1 line, -56 lines 0 comments Download
M third_party/WebKit/Source/core/plugins/PluginView.h View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp View 1 1 chunk +2 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/web/WebPluginContainerImpl.h View 1 2 3 4 5 6 7 8 9 3 chunks +1 line, -10 lines 0 comments Download
M third_party/WebKit/Source/web/WebPluginContainerImpl.cpp View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -19 lines 0 comments Download
M third_party/WebKit/public/features.gni View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 38 (19 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511413003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511413003/1
5 years ago (2015-12-10 13:28:01 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/25374)
5 years ago (2015-12-10 13:45:15 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511413003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511413003/20001
5 years ago (2015-12-10 14:10:48 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/91289)
5 years ago (2015-12-10 14:47:38 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511413003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511413003/40001
5 years ago (2015-12-10 15:40:37 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/91346)
5 years ago (2015-12-10 16:38:32 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511413003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511413003/60001
5 years ago (2015-12-11 06:47:15 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511413003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511413003/80001
5 years ago (2015-12-11 07:15:04 UTC) #16
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/91379) mac_chromium_rel_ng on ...
5 years ago (2015-12-11 08:13:50 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511413003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511413003/100001
5 years ago (2015-12-11 09:06:01 UTC) #20
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/143708)
5 years ago (2015-12-11 10:11:16 UTC) #22
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511413003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511413003/120001
5 years ago (2015-12-11 12:56:23 UTC) #24
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/132783) linux_chromium_chromeos_rel_ng on ...
5 years ago (2015-12-11 13:29:31 UTC) #26
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511413003/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511413003/140001
5 years ago (2015-12-11 14:22:23 UTC) #28
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/135344) mac_chromium_gn_rel on ...
5 years ago (2015-12-11 14:24:03 UTC) #30
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511413003/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511413003/160001
5 years ago (2015-12-11 14:51:35 UTC) #32
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/154790)
5 years ago (2015-12-11 16:18:21 UTC) #34
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511413003/170001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511413003/170001
5 years ago (2015-12-12 14:24:55 UTC) #36
commit-bot: I haz the power
5 years ago (2015-12-12 15:54:18 UTC) #38 
Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698