Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1377)

Unified Diff: scripts/slave/recipes/android_webview_aosp_perf.py

Issue 1511403002: Revert "[Android] Add context manager to record logcat during step(s)." (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/android_webview_aosp_perf.py
diff --git a/scripts/slave/recipes/android_webview_aosp_perf.py b/scripts/slave/recipes/android_webview_aosp_perf.py
index 1e03785899692a4cb85cf01dbb34715deb45315e..b97d7f2530390ec0c4121cb09b92239d1fc9cfd6 100644
--- a/scripts/slave/recipes/android_webview_aosp_perf.py
+++ b/scripts/slave/recipes/android_webview_aosp_perf.py
@@ -77,9 +77,8 @@ def RunSteps(api):
chartjson_file=True,
perf_id=BUILDER['perf_id'])
finally:
- logcat_file = api.chromium.output_dir.join('full_logcat')
- api.chromium_android.logcat_dump(output_logcat_file=logcat_file)
- api.chromium_android.stack_tool_steps(logcat_file=logcat_file)
+ api.chromium_android.logcat_dump()
+ api.chromium_android.stack_tool_steps()
api.chromium_android.test_report()

Powered by Google App Engine
This is Rietveld 408576698