scripts/slave/recipes/android_webview_aosp_perf.py - Issue 1511403002: Revert "[Android] Add context manager to record logcat during step(s)."

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/slave/recipes/android_webview_aosp_perf.py

Issue 1511403002: Revert "[Android] Add context manager to record logcat during step(s)." (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « scripts/slave/recipes/android/perf.expected/src_side_script_fails.json ('k') | scripts/slave/recipes/android_webview_aosp_perf.expected/basic.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 """	5 """

6 Performance testing for the WebView.	6 Performance testing for the WebView.

7 """	7 """

8	8

9 from recipe_engine.types import freeze	9 from recipe_engine.types import freeze

10	10

(...skipping 59 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
70 perf_tests = api.chromium.list_perf_tests(	70 perf_tests = api.chromium.list_perf_tests(

71 browser='android-webview',	71 browser='android-webview',

72 num_shards=BUILDER['num_device_shards'],	72 num_shards=BUILDER['num_device_shards'],

73 device=api.adb.devices[0]).json.output	73 device=api.adb.devices[0]).json.output

74 try:	74 try:

75 api.chromium_android.run_sharded_perf_tests(	75 api.chromium_android.run_sharded_perf_tests(

76 config=api.json.input(data=perf_tests),	76 config=api.json.input(data=perf_tests),

77 chartjson_file=True,	77 chartjson_file=True,

78 perf_id=BUILDER['perf_id'])	78 perf_id=BUILDER['perf_id'])

79 finally:	79 finally:

80 logcat_file = api.chromium.output_dir.join('full_logcat')	80 api.chromium_android.logcat_dump()

81 api.chromium_android.logcat_dump(output_logcat_file=logcat_file)	81 api.chromium_android.stack_tool_steps()

82 api.chromium_android.stack_tool_steps(logcat_file=logcat_file)

83 api.chromium_android.test_report()	82 api.chromium_android.test_report()

84	83

85	84

86 def GenTests(api):	85 def GenTests(api):

87 yield api.test('basic') + api.properties.scheduled()	86 yield api.test('basic') + api.properties.scheduled()

OLD	NEW