Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: src/compiler/mips64/code-generator-mips64.cc

Issue 1511223002: MIPS: [turbofan] Fix Div operations by zero on r6. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/mips/code-generator-mips.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/mips64/code-generator-mips64.cc
diff --git a/src/compiler/mips64/code-generator-mips64.cc b/src/compiler/mips64/code-generator-mips64.cc
index 56c6fe19615c38b5df3c1db4b3a9f86351d57c00..9788652b4568d1f22729f79c301fdb2054535cc8 100644
--- a/src/compiler/mips64/code-generator-mips64.cc
+++ b/src/compiler/mips64/code-generator-mips64.cc
@@ -649,7 +649,7 @@ void CodeGenerator::AssembleArchInstruction(Instruction* instr) {
case kMips64Div:
__ Div(i.OutputRegister(), i.InputRegister(0), i.InputOperand(1));
if (kArchVariant == kMips64r6) {
- __ seleqz(i.OutputRegister(), i.InputRegister(0), i.InputRegister(0));
+ __ selnez(i.OutputRegister(), i.InputRegister(1), i.InputRegister(0));
} else {
__ Movz(i.OutputRegister(), i.InputRegister(1), i.InputRegister(1));
}
@@ -657,7 +657,7 @@ void CodeGenerator::AssembleArchInstruction(Instruction* instr) {
case kMips64DivU:
__ Divu(i.OutputRegister(), i.InputRegister(0), i.InputOperand(1));
if (kArchVariant == kMips64r6) {
- __ seleqz(i.OutputRegister(), i.InputRegister(0), i.InputRegister(0));
+ __ selnez(i.OutputRegister(), i.InputRegister(1), i.InputRegister(0));
} else {
__ Movz(i.OutputRegister(), i.InputRegister(1), i.InputRegister(1));
}
@@ -674,7 +674,7 @@ void CodeGenerator::AssembleArchInstruction(Instruction* instr) {
case kMips64Ddiv:
__ Ddiv(i.OutputRegister(), i.InputRegister(0), i.InputOperand(1));
if (kArchVariant == kMips64r6) {
- __ seleqz(i.OutputRegister(), i.InputRegister(0), i.InputRegister(0));
+ __ selnez(i.OutputRegister(), i.InputRegister(1), i.InputRegister(0));
} else {
__ Movz(i.OutputRegister(), i.InputRegister(1), i.InputRegister(1));
}
@@ -682,7 +682,7 @@ void CodeGenerator::AssembleArchInstruction(Instruction* instr) {
case kMips64DdivU:
__ Ddivu(i.OutputRegister(), i.InputRegister(0), i.InputOperand(1));
if (kArchVariant == kMips64r6) {
- __ seleqz(i.OutputRegister(), i.InputRegister(0), i.InputRegister(0));
+ __ selnez(i.OutputRegister(), i.InputRegister(1), i.InputRegister(0));
} else {
__ Movz(i.OutputRegister(), i.InputRegister(1), i.InputRegister(1));
}
« no previous file with comments | « src/compiler/mips/code-generator-mips.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698