Issue 15112004: Simplify RenderFlexibleBox::computeMainAxisExtentForChild

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15112004: Simplify RenderFlexibleBox::computeMainAxisExtentForChild (Closed)

Created:
7 years, 7 months ago by cbiesinger

Modified:
7 years, 7 months ago

Reviewers:
ojan

CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Simplify RenderFlexibleBox::computeMainAxisExtentForChild We only need to check size.isIntrinsic(), not all of height/min-height/max-height. We can also use layoutIfNeeded(). No new tests - no behavior change. R=ojan@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150355

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -5 lines)			Patch
	M	Source/core/rendering/RenderFlexibleBox.cpp	View		1 chunk	+3 lines, -5 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cbiesinger@chromium.org/15112004/1

7 years, 7 months ago (2013-05-14 19:24:06 UTC) #3

Message was sent while issue was closed.

Change committed as 150355