Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 1511143002: Reland of Fix several corner case issues of scrollbar paint invalidation (Closed)

Created:
5 years ago by sof
Modified:
5 years ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Fix several corner case issues of scrollbar paint invalidation (patchset #1 id:1 of https://codereview.chromium.org/1513573004/ ) Reason for revert: Thanks for looking after the health of Oilpan builds. But as Oilpan is yet to be CQ-blocking, we don't want to be unnecessarily causing post-landing revert consternation & be in the way of overall progress. Hence, I'm going to undo this revert & address the problem the Oilpan static checks are picking up on; it's a trivial one. Original issue's description: > Revert of Fix several corner case issues of scrollbar paint invalidation (patchset #7 id:120001 of https://codereview.chromium.org/1491193003/ ) > > Reason for revert: > I suspect this may have broken the Oilpan build: > > https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac%20Oilpan/builds/27442 > > Original issue's description: > > Fix several corner case issues of scrollbar paint invalidation > > > > - Invalidate composited scrollbars also during paint invalidation to > > avoid unnecessary invalidation on intermediate changes; > > > > - Invalidate also on the containing box for moved/resized composited > > non-overlay scrollbars. This ensures the expanded/shrunk areas of the > > box because of scrollbar existence/width change are invalidated. This > > is the root cause of bug 535161. > > > > - Avoid unnecessary invalidations on overlay scrollbar changes. > > > > BUG=535161, 560418 > > > > Committed: https://crrev.com/48e402acbebf2717b8e79b89dba5310d31bf95da > > Cr-Commit-Position: refs/heads/master@{#363998} > > TBR=chrishtr@chromium.org,skobes@chromium.org,wangxianzhu@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=535161, 560418 > > Committed: https://crrev.com/ed0577e5a8952de3976d6b18fa0ed39fe2a0e418 > Cr-Commit-Position: refs/heads/master@{#364000} TBR=chrishtr@chromium.org,skobes@chromium.org,wangxianzhu@chromium.org,dominicc@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=535161, 560418 Committed: https://crrev.com/435854e8b327de68a00cdbec8d7e6c6f07658cbe Cr-Commit-Position: refs/heads/master@{#364006}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -68 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/repaint/destroy-composited-scrollbar.html View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/repaint/destroy-composited-scrollbar-expected.txt View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/repaint/destroy-overlay-scrollbar.html View 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/repaint/destroy-overlay-scrollbar-expected.txt View 1 chunk +19 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/destroy-scrollbar-expected.txt View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/layout-state-only-positioned-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/overflow-scroll-body-appear-expected.txt View 2 chunks +11 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/resize-scrollable-div-expected.txt View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/scrollbar-invalidation-on-resize-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/scrollbar-invalidation-on-resize-with-border-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/repaint/details-open-repaint-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/repaint/overflow-scroll-body-appear-expected.txt View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/repaint/resize-scrollable-iframe-expected.txt View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 2 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 2 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.h View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.cpp View 4 chunks +72 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
Created Reland of Fix several corner case issues of scrollbar paint invalidation
5 years ago (2015-12-09 08:25:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511143002/1
5 years ago (2015-12-09 08:27:12 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-09 08:29:40 UTC) #4
commit-bot: I haz the power
5 years ago (2015-12-09 08:30:22 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/435854e8b327de68a00cdbec8d7e6c6f07658cbe
Cr-Commit-Position: refs/heads/master@{#364006}

Powered by Google App Engine
This is Rietveld 408576698