Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Side by Side Diff: third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp

Issue 1511143002: Reland of Fix several corner case issues of scrollbar paint invalidation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2009, 2010 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 315 matching lines...) Expand 10 before | Expand all | Expand 10 after
326 if (updateType >= CompositingUpdateAfterCompositingInputChange) 326 if (updateType >= CompositingUpdateAfterCompositingInputChange)
327 CompositingInputsUpdater(rootLayer()).update(); 327 CompositingInputsUpdater(rootLayer()).update();
328 328
329 #if ENABLE(ASSERT) 329 #if ENABLE(ASSERT)
330 CompositingInputsUpdater::assertNeedsCompositingInputsUpdateBitsCleared(root Layer()); 330 CompositingInputsUpdater::assertNeedsCompositingInputsUpdateBitsCleared(root Layer());
331 #endif 331 #endif
332 } 332 }
333 333
334 static void forceRecomputePaintInvalidationRectsIncludingNonCompositingDescendan ts(LayoutObject* layoutObject) 334 static void forceRecomputePaintInvalidationRectsIncludingNonCompositingDescendan ts(LayoutObject* layoutObject)
335 { 335 {
336 // We clear the previous paint invalidation rect as it's wrong (paint invali ation container 336 // We clear the previous paint invalidation rect as it's wrong (paint invali dation container
337 // changed, ...). Forcing a full invalidation will make us recompute it. Als o we are not 337 // changed, ...). Forcing a full invalidation will make us recompute it. Als o we are not
338 // changing the previous position from our paint invalidation container, whi ch is fine as 338 // changing the previous position from our paint invalidation container, whi ch is fine as
339 // we want a full paint invalidation anyway. 339 // we want a full paint invalidation anyway.
340 layoutObject->setPreviousPaintInvalidationRect(LayoutRect()); 340 layoutObject->clearPreviousPaintInvalidationRects();
341 layoutObject->setShouldDoFullPaintInvalidation(); 341 layoutObject->setShouldDoFullPaintInvalidation();
342 342
343 for (LayoutObject* child = layoutObject->slowFirstChild(); child; child = ch ild->nextSibling()) { 343 for (LayoutObject* child = layoutObject->slowFirstChild(); child; child = ch ild->nextSibling()) {
344 if (!child->isPaintInvalidationContainer()) 344 if (!child->isPaintInvalidationContainer())
345 forceRecomputePaintInvalidationRectsIncludingNonCompositingDescendan ts(child); 345 forceRecomputePaintInvalidationRectsIncludingNonCompositingDescendan ts(child);
346 } 346 }
347 } 347 }
348 348
349 349
350 void PaintLayerCompositor::updateIfNeeded() 350 void PaintLayerCompositor::updateIfNeeded()
(...skipping 855 matching lines...) Expand 10 before | Expand all | Expand 10 after
1206 } else if (graphicsLayer == m_scrollLayer.get()) { 1206 } else if (graphicsLayer == m_scrollLayer.get()) {
1207 name = "Frame Scrolling Layer"; 1207 name = "Frame Scrolling Layer";
1208 } else { 1208 } else {
1209 ASSERT_NOT_REACHED(); 1209 ASSERT_NOT_REACHED();
1210 } 1210 }
1211 1211
1212 return name; 1212 return name;
1213 } 1213 }
1214 1214
1215 } // namespace blink 1215 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698