Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Issue 1511123006: Uprev NSS (in libssl) to NSS 3.21 (Closed)

Created:
5 years ago by Ryan Sleevi
Modified:
5 years ago
Reviewers:
Dirk Pranke, davidben
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, cbentzel+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Uprev NSS (in libssl) to NSS 3.21 Update the bundled libssl to use NSS 3.21. This removes the patches for DHE 1024-bit, lock ordering, and build metadata, which are all upstreamed. Upstream has added a dhe-param.c file, but this is intentionally not added to build targets, as it's simply #included from another C file. BUG=568855 Committed: https://crrev.com/95065347187475b6a60fdff82d87153dce14892f Cr-Commit-Position: refs/heads/master@{#366244}

Patch Set 1 #

Total comments: 1

Patch Set 2 : And roll DEPS #

Patch Set 3 : Updated deps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3168 lines, -1393 lines) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M build/secondary/third_party/nss/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M net/third_party/nss/README.chromium View 3 chunks +2 lines, -12 lines 0 comments Download
M net/third_party/nss/patches/aesgcmchromium.patch View 6 chunks +9 lines, -9 lines 0 comments Download
M net/third_party/nss/patches/applypatches.sh View 1 chunk +0 lines, -6 lines 0 comments Download
M net/third_party/nss/patches/cachecerts.patch View 7 chunks +19 lines, -19 lines 0 comments Download
M net/third_party/nss/patches/cachelocks.patch View 7 chunks +21 lines, -21 lines 0 comments Download
M net/third_party/nss/patches/chacha20poly1305.patch View 17 chunks +54 lines, -54 lines 0 comments Download
M net/third_party/nss/patches/channelid.patch View 26 chunks +91 lines, -90 lines 0 comments Download
M net/third_party/nss/patches/cipherorder.patch View 4 chunks +23 lines, -23 lines 0 comments Download
M net/third_party/nss/patches/clientauth.patch View 23 chunks +47 lines, -47 lines 0 comments Download
D net/third_party/nss/patches/dh1024.patch View 1 chunk +0 lines, -14 lines 0 comments Download
M net/third_party/nss/patches/didhandshakeresume.patch View 2 chunks +10 lines, -10 lines 0 comments Download
M net/third_party/nss/patches/getrequestedclientcerttypes.patch View 6 chunks +24 lines, -24 lines 0 comments Download
D net/third_party/nss/patches/norenegotiatelock.patch View 1 chunk +0 lines, -15 lines 0 comments Download
M net/third_party/nss/patches/nssrwlock.patch View 17 chunks +28 lines, -28 lines 0 comments Download
D net/third_party/nss/patches/removebuildmetadata.patch View 1 chunk +0 lines, -27 lines 0 comments Download
M net/third_party/nss/patches/reorderextensions.patch View 2 chunks +7 lines, -7 lines 0 comments Download
M net/third_party/nss/patches/restartclientauth.patch View 4 chunks +20 lines, -20 lines 0 comments Download
M net/third_party/nss/patches/secitemarray.patch View 2 chunks +10 lines, -10 lines 0 comments Download
M net/third_party/nss/patches/secretexporterlocks.patch View 3 chunks +7 lines, -7 lines 0 comments Download
M net/third_party/nss/patches/sessioncache.patch View 3 chunks +15 lines, -15 lines 0 comments Download
M net/third_party/nss/patches/signedcertificatetimestamps.patch View 17 chunks +92 lines, -79 lines 0 comments Download
M net/third_party/nss/patches/suitebonly.patch View 2 chunks +6 lines, -6 lines 0 comments Download
M net/third_party/nss/patches/tls12chromium.patch View 5 chunks +17 lines, -16 lines 0 comments Download
M net/third_party/nss/patches/tlsunique.patch View 5 chunks +27 lines, -26 lines 0 comments Download
M net/third_party/nss/ssl/SSLerrs.h View 1 chunk +21 lines, -3 lines 0 comments Download
M net/third_party/nss/ssl/derive.c View 1 chunk +1 line, -1 line 0 comments Download
A net/third_party/nss/ssl/dhe-param.c View 1 chunk +413 lines, -0 lines 0 comments Download
M net/third_party/nss/ssl/dtlscon.c View 4 chunks +4 lines, -6 lines 0 comments Download
M net/third_party/nss/ssl/ssl.h View 3 chunks +112 lines, -3 lines 0 comments Download
M net/third_party/nss/ssl/ssl3con.c View 157 chunks +1285 lines, -518 lines 0 comments Download
M net/third_party/nss/ssl/ssl3ecc.c View 13 chunks +27 lines, -21 lines 0 comments Download
M net/third_party/nss/ssl/ssl3ext.c View 51 chunks +234 lines, -107 lines 0 comments Download
M net/third_party/nss/ssl/ssl3gthr.c View 1 chunk +2 lines, -2 lines 0 comments Download
M net/third_party/nss/ssl/ssl3prot.h View 2 chunks +2 lines, -28 lines 0 comments Download
M net/third_party/nss/ssl/sslauth.c View 1 chunk +1 line, -2 lines 0 comments Download
M net/third_party/nss/ssl/sslcon.c View 11 chunks +12 lines, -28 lines 0 comments Download
M net/third_party/nss/ssl/sslenum.c View 1 chunk +3 lines, -0 lines 0 comments Download
M net/third_party/nss/ssl/sslerr.h View 1 chunk +13 lines, -3 lines 0 comments Download
M net/third_party/nss/ssl/sslimpl.h View 17 chunks +57 lines, -22 lines 0 comments Download
M net/third_party/nss/ssl/sslinfo.c View 6 chunks +43 lines, -6 lines 0 comments Download
M net/third_party/nss/ssl/sslmutex.h View 3 chunks +7 lines, -2 lines 0 comments Download
M net/third_party/nss/ssl/sslmutex.c View 1 chunk +1 line, -1 line 0 comments Download
M net/third_party/nss/ssl/sslproto.h View 2 chunks +2 lines, -0 lines 0 comments Download
M net/third_party/nss/ssl/sslsecur.c View 5 chunks +19 lines, -3 lines 0 comments Download
M net/third_party/nss/ssl/sslsnce.c View 6 chunks +55 lines, -33 lines 0 comments Download
M net/third_party/nss/ssl/sslsock.c View 13 chunks +260 lines, -1 line 0 comments Download
M net/third_party/nss/ssl/sslt.h View 5 chunks +59 lines, -2 lines 0 comments Download
M net/third_party/nss/ssl/sslver.c View 1 chunk +2 lines, -15 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Ryan Sleevi
David: Another update. This will be updated with a DEPS rev once the related CL ...
5 years ago (2015-12-11 01:28:45 UTC) #2
davidben
lgtm. I really only glossed over this though, since it's otherwise kind of huge. I ...
5 years ago (2015-12-11 22:40:58 UTC) #3
Ryan Sleevi
Dirk: Could you stampy the GN file
5 years ago (2015-12-17 22:07:35 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511123006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511123006/20001
5 years ago (2015-12-17 22:10:01 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/109447) ios_rel_device_ninja on ...
5 years ago (2015-12-17 22:16:21 UTC) #9
Dirk Pranke
lgtm
5 years ago (2015-12-17 23:47:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511123006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511123006/40001
5 years ago (2015-12-19 00:03:07 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-19 01:21:37 UTC) #14
commit-bot: I haz the power
5 years ago (2015-12-19 01:22:28 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/95065347187475b6a60fdff82d87153dce14892f
Cr-Commit-Position: refs/heads/master@{#366244}

Powered by Google App Engine
This is Rietveld 408576698