Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Side by Side Diff: net/third_party/nss/patches/reorderextensions.patch

Issue 1511123006: Uprev NSS (in libssl) to NSS 3.21 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated deps Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 diff --git a/ssl/ssl3ext.c b/ssl/ssl3ext.c 1 diff --git a/lib/ssl/ssl3ext.c b/lib/ssl/ssl3ext.c
2 index c18d6f6..9214a2e 100644 2 index 9cfd541..eb3fb70 100644
3 --- a/ssl/ssl3ext.c 3 --- a/lib/ssl/ssl3ext.c
4 +++ b/ssl/ssl3ext.c 4 +++ b/lib/ssl/ssl3ext.c
5 @@ -313,6 +313,10 @@ ssl3HelloExtensionSender clientHelloSendersTLS[SSL_MAX_EXTE NSIONS] = { 5 @@ -321,6 +321,10 @@ ssl3HelloExtensionSender clientHelloSendersTLS[SSL_MAX_EXTE NSIONS] = {
6 { ssl_cert_status_xtn, &ssl3_ClientSendStatusRequestXtn }, 6 { ssl_cert_status_xtn, &ssl3_ClientSendStatusRequestXtn },
7 { ssl_signed_certificate_timestamp_xtn, 7 { ssl_signed_certificate_timestamp_xtn,
8 &ssl3_ClientSendSignedCertTimestampXtn }, 8 &ssl3_ClientSendSignedCertTimestampXtn },
9 + /* WebSphere Application Server 7.0 is intolerant to the last extension 9 + /* WebSphere Application Server 7.0 is intolerant to the last extension
10 + * being zero-length. It is not intolerant of TLS 1.2, so ensure that 10 + * being zero-length. It is not intolerant of TLS 1.2, so ensure that
11 + * signature_algorithms is at the end to guarantee a non-empty 11 + * signature_algorithms is at the end to guarantee a non-empty
12 + * extension. */ 12 + * extension. */
13 { ssl_signature_algorithms_xtn, &ssl3_ClientSendSigAlgsXtn }, 13 { ssl_signature_algorithms_xtn, &ssl3_ClientSendSigAlgsXtn },
14 { ssl_tls13_draft_version_xtn, &ssl3_ClientSendDraftVersionXtn }, 14 { ssl_tls13_draft_version_xtn, &ssl3_ClientSendDraftVersionXtn },
15 /* any extra entries will appear as { 0, NULL } */ 15 { ssl_extended_master_secret_xtn, &ssl3_SendExtendedMasterSecretXtn},
16 @@ -2507,9 +2511,11 @@ ssl3_CalculatePaddingExtensionLength(unsigned int clientH elloLength) 16 @@ -2546,9 +2550,11 @@ ssl3_CalculatePaddingExtensionLength(unsigned int clientH elloLength)
17 } 17 }
18 18
19 extensionLength = 512 - recordLength; 19 extensionLength = 512 - recordLength;
20 - /* Extensions take at least four bytes to encode. */ 20 - /* Extensions take at least four bytes to encode. */
21 - if (extensionLength < 4) { 21 - if (extensionLength < 4) {
22 - extensionLength = 4; 22 - extensionLength = 4;
23 + /* Extensions take at least four bytes to encode. Always include at least 23 + /* Extensions take at least four bytes to encode. Always include at least
24 + * one byte of data if including the extension. WebSphere Application 24 + * one byte of data if including the extension. WebSphere Application
25 + * Server 7.0 is intolerant to the last extension being zero-length. */ 25 + * Server 7.0 is intolerant to the last extension being zero-length. */
26 + if (extensionLength < 4 + 1) { 26 + if (extensionLength < 4 + 1) {
27 + extensionLength = 4 + 1; 27 + extensionLength = 4 + 1;
28 } 28 }
29 29
30 return extensionLength; 30 return extensionLength;
OLDNEW
« no previous file with comments | « net/third_party/nss/patches/removebuildmetadata.patch ('k') | net/third_party/nss/patches/restartclientauth.patch » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698