Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: extensions/common/test_util.h

Issue 1511103003: Use rvalue reference instead of ExtensionBuilder::pass() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review (returning rvalue) Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/extension_builder.cc ('k') | extensions/common/test_util.cc » ('j') | extensions/common/test_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/test_util.h
diff --git a/extensions/common/test_util.h b/extensions/common/test_util.h
index 0f02ac0e54be57e62523b58f54a005f6e5be7efd..722039944191e292c03130381af6d8a4faa3a205 100644
--- a/extensions/common/test_util.h
+++ b/extensions/common/test_util.h
@@ -16,10 +16,10 @@ class ExtensionBuilder;
namespace test_util {
// Adds an extension manifest to a builder.
-ExtensionBuilder& BuildExtension(ExtensionBuilder& builder);
+ExtensionBuilder BuildExtension(ExtensionBuilder builder);
// Adds an app manifest to a builder.
-ExtensionBuilder& BuildApp(ExtensionBuilder& builder);
+ExtensionBuilder BuildApp(ExtensionBuilder builder);
// Creates an extension instance that can be attached to an ExtensionFunction
// before running it.
« no previous file with comments | « extensions/common/extension_builder.cc ('k') | extensions/common/test_util.cc » ('j') | extensions/common/test_util.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698