Use rvalue reference instead of ExtensionBuilder::pass()

extensions/common/test_util.cc

Index: extensions/common/test_util.cc
diff --git a/extensions/common/test_util.cc b/extensions/common/test_util.cc
index 9a9312a3fc15aaa57da75fd186bba8e64e9d29ff..c8086d6ac2a0a35e730b50edda348e6812f25fbb 100644
--- a/extensions/common/test_util.cc
+++ b/extensions/common/test_util.cc
@@ -13,16 +13,15 @@
 namespace extensions {
 namespace test_util {
 
-ExtensionBuilder& BuildExtension(ExtensionBuilder& builder) {
-  return builder
-         .SetManifest(DictionaryBuilder()
-                      .Set("name", "Test extension")
-                      .Set("version", "1.0")
-                      .Set("manifest_version", 2));
+ExtensionBuilder BuildExtension(ExtensionBuilder builder) {
+  return std::move(builder.SetManifest(DictionaryBuilder()

[danakj, 2015/12/17 22:22:02]

nit: it might be easier to read these if you wrote it as

  builder.SetManifest(....);
  return std::move(builder);

[limasdf, 2015/12/18 00:31:58]

Thank you. |builder| is rvalue, just returning without std::move.

builder.SetManifest(....);
return builder;

[danakj, 2015/12/18 00:38:49]

Ah, right return will make it an rvalue :) Thanks!

+                                           .Set("name", "Test extension")
+                                           .Set("version", "1.0")
+                                           .Set("manifest_version", 2)));
 }
 
-ExtensionBuilder& BuildApp(ExtensionBuilder& builder) {
-  return builder.SetManifest(
+ExtensionBuilder BuildApp(ExtensionBuilder builder) {
+  return std::move(builder.SetManifest(
       DictionaryBuilder()
           .Set("name", "Test extension")
           .Set("version", "1.0")
@@ -32,7 +31,7 @@ ExtensionBuilder& BuildApp(ExtensionBuilder& builder) {
                    "background",
                    extensions::DictionaryBuilder().Set(
                        "scripts", std::move(extensions::ListBuilder().Append(
-                                      "background.js"))))));
+                                      "background.js")))))));
 }
 
 scoped_refptr<Extension> CreateEmptyExtension() {