Use rvalue reference instead of ExtensionBuilder::pass()

extensions/common/extension_builder.cc

Index: extensions/common/extension_builder.cc
diff --git a/extensions/common/extension_builder.cc b/extensions/common/extension_builder.cc
index f993e9467ac89758efc2c1e50f0fe50c82d2d4a6..1910a8e79379bc441819a5fd44f6a170f3cbbee2 100644
--- a/extensions/common/extension_builder.cc
+++ b/extensions/common/extension_builder.cc
@@ -14,6 +14,13 @@ ExtensionBuilder::ExtensionBuilder()
 }
 ExtensionBuilder::~ExtensionBuilder() {}
 
+ExtensionBuilder::ExtensionBuilder(ExtensionBuilder&& other)
+    : path_(other.path_),

[danakj, 2015/12/09 18:46:44]

move the string instead of copying it?

[limasdf, 2015/12/16 09:34:54]

Done.

+      location_(other.location_),
+      manifest_(other.manifest_.release()),

[danakj, 2015/12/09 18:46:44]

why isn't this manifest_(std::move(other.manifest_))?

[limasdf, 2015/12/16 09:34:54]

Done.

+      flags_(other.flags_),
+      id_(other.id_) {}

[danakj, 2015/12/09 18:46:44]

move the string dont copy?

[limasdf, 2015/12/16 09:34:54]

Done.

+
 scoped_refptr<Extension> ExtensionBuilder::Build() {
   std::string error;
   scoped_refptr<Extension> extension = Extension::Create(