Use rvalue reference instead of ExtensionBuilder::pass()

extensions/common/extension_builder.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/common/extension_builder.h"
 
 #include "extensions/common/extension.h"
 
 namespace extensions {
 
 ExtensionBuilder::ExtensionBuilder()
     : location_(Manifest::UNPACKED),
       flags_(Extension::NO_FLAGS) {
 }
 ExtensionBuilder::~ExtensionBuilder() {}
 
+ExtensionBuilder::ExtensionBuilder(ExtensionBuilder&& other)
+    : path_(other.path_),

[danakj, 2015/12/09 18:46:44]

move the string instead of copying it?

[limasdf, 2015/12/16 09:34:54]

Done.

+      location_(other.location_),
+      manifest_(other.manifest_.release()),

[danakj, 2015/12/09 18:46:44]

why isn't this manifest_(std::move(other.manifest_))?

[limasdf, 2015/12/16 09:34:54]

Done.

+      flags_(other.flags_),
+      id_(other.id_) {}

[danakj, 2015/12/09 18:46:44]

move the string dont copy?

[limasdf, 2015/12/16 09:34:54]

Done.

+
 scoped_refptr<Extension> ExtensionBuilder::Build() {
   std::string error;
   scoped_refptr<Extension> extension = Extension::Create(
       path_,
       location_,
       *manifest_,
       flags_,
       id_,
       &error);
   CHECK_EQ("", error);
@@ skipping 25 matching lines @@
   flags_ |= init_from_value_flags;
   return *this;
 }
 
 ExtensionBuilder& ExtensionBuilder::SetID(const std::string& id) {
   id_ = id;
   return *this;
 }
 
 }  // namespace extensions