Use rvalue reference instead of ExtensionBuilder::pass()

extensions/common/test_util.cc

Index: extensions/common/test_util.cc
diff --git a/extensions/common/test_util.cc b/extensions/common/test_util.cc
index 9a9312a3fc15aaa57da75fd186bba8e64e9d29ff..6def1b9550a4e53be0d14620e4cf89a3613db98a 100644
--- a/extensions/common/test_util.cc
+++ b/extensions/common/test_util.cc
@@ -13,7 +13,7 @@
 namespace extensions {
 namespace test_util {
 
-ExtensionBuilder& BuildExtension(ExtensionBuilder& builder) {
+ExtensionBuilder& BuildExtension(ExtensionBuilder builder) {
   return builder

[danakj, 2015/12/16 18:57:49]

This is now returning a reference to a temporary variable. Return by value.

[danakj, 2015/12/16 19:06:04]

er, local, not temporary, but it's bad :) the variable is destroyed when this
function leaves scope

[limasdf, 2015/12/17 06:19:46]

Returning rvalue should work.

          .SetManifest(DictionaryBuilder()
                       .Set("name", "Test extension")
@@ -21,7 +21,7 @@ ExtensionBuilder& BuildExtension(ExtensionBuilder& builder) {
                       .Set("manifest_version", 2));
 }
 
-ExtensionBuilder& BuildApp(ExtensionBuilder& builder) {
+ExtensionBuilder& BuildApp(ExtensionBuilder builder) {

[danakj, 2015/12/16 18:57:49]

ditto

[limasdf, 2015/12/17 06:19:46]

ditto-ly done.

   return builder.SetManifest(
       DictionaryBuilder()
           .Set("name", "Test extension")