Use rvalue reference instead of ExtensionBuilder::pass()

extensions/common/test_util.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/common/test_util.h"
 
 #include <utility>
 
 #include "extensions/common/extension.h"
 #include "extensions/common/extension_builder.h"
 #include "extensions/common/value_builder.h"
 
 namespace extensions {
 namespace test_util {
 
-ExtensionBuilder& BuildExtension(ExtensionBuilder& builder) {
+ExtensionBuilder& BuildExtension(ExtensionBuilder builder) {
   return builder

[danakj, 2015/12/16 18:57:49]

This is now returning a reference to a temporary variable. Return by value.

[danakj, 2015/12/16 19:06:04]

er, local, not temporary, but it's bad :) the variable is destroyed when this
function leaves scope

[limasdf, 2015/12/17 06:19:46]

Returning rvalue should work.

          .SetManifest(DictionaryBuilder()
                       .Set("name", "Test extension")
                       .Set("version", "1.0")
                       .Set("manifest_version", 2));
 }
 
-ExtensionBuilder& BuildApp(ExtensionBuilder& builder) {
+ExtensionBuilder& BuildApp(ExtensionBuilder builder) {

[danakj, 2015/12/16 18:57:49]

ditto

[limasdf, 2015/12/17 06:19:46]

ditto-ly done.

   return builder.SetManifest(
       DictionaryBuilder()
           .Set("name", "Test extension")
           .Set("version", "1.0")
           .Set("manifest_version", 2)
           .Set("app",
                extensions::DictionaryBuilder().Set(
                    "background",
                    extensions::DictionaryBuilder().Set(
                        "scripts", std::move(extensions::ListBuilder().Append(
@@ skipping 10 matching lines @@
 scoped_refptr<Extension> CreateEmptyExtension(const std::string& id) {
   return ExtensionBuilder()
       .SetManifest(
            DictionaryBuilder().Set("name", "test").Set("version", "0.1"))
       .SetID(id)
       .Build();
 }
 
 }  // namespace test_util
 }  // namespace extensions