[DevTools] Evaluate expression like { ... } as Object Literal

[DevTools] Evaluate expression like { ... } as Object Literal

If user evaluate in console expression like {a:1, b:2} then console will report SyntaxError exception because this expression is interpreted as block scope declaration with incorrect label.
With this CL console wrap all expressions that begins with { and ends with }.

BUG=499864
R=paulirish@chromium.org, pfeldman@chromium.org

Committed: https://crrev.com/4fd348fdb9c0b3842829acdfb2b82c86dacd8e0a
Cr-Commit-Position: refs/heads/master@{#364270}

[kozy, 2015-12-09 01:28:11]

ptal

[kozy, 2015-12-09 01:28:56]

Description was changed from

==========
[DevTools] Reevaluating input as object on SyntaxError Unexpected token :

If user evaluate in console expression like {a:1, b:2} then console will report
SyntaxError exception because this expression is interpreted as block scope
declaration with incorrect label.
With this CL console will reevaluate expression with parentheses and if there is
no exceptions will output debug message for user "Reevaluating input as an
object literal.." and result object.

BUG=499864
R=paulirish@chromium.org, pfeldman@chromium.org
==========

to

==========
[DevTools] Reevaluating input as object on SyntaxError Unexpected token :

If user evaluate in console expression like {a:1, b:2} then console will report
SyntaxError exception because this expression is interpreted as block scope
declaration with incorrect label.
With this CL console will reevaluate expression with parentheses and if there is
no exceptions will output debug message for user "Reevaluating input as an
object literal.." and result object. Origin result with SyntaxError exception
will be output too.

BUG=499864
R=paulirish@chromium.org, pfeldman@chromium.org
==========

[kozy, 2015-12-09 01:35:31]

Screenshot:
https://drive.google.com/file/d/0B7RLEApsOKBLbE1zZkRmVWJ5NTg/view?usp=sharing

[paulirish, 2015-12-09 01:35:39]

I like it. Yup this matches exactly what folks on the thread want.

[pfeldman, 2015-12-09 03:23:36]

We should never eval things twice. What does it result in for {a:b++} now? :)

not lgtm

[kozy, 2015-12-09 03:47:48]

On 2015/12/09 03:23:36, pfeldman wrote:
> We should never eval things twice. What does it result in for {a:b++} now? :)
> 
> not lgtm

Pavel, I think that we don't evaluate scripts with SyntaxError. I can provide
additional flag in exception details: hadSyntaxError and reevaluate only in this
case and I should add check that SyntaxError was thrown by top stack frame for
ignore cases like eval("{a:1, b:2}");. With flag and checking stack we will
never evaluate script twice.
WDYT?

[kozy, 2015-12-09 23:01:14]

Description was changed from

==========
[DevTools] Reevaluating input as object on SyntaxError Unexpected token :

If user evaluate in console expression like {a:1, b:2} then console will report
SyntaxError exception because this expression is interpreted as block scope
declaration with incorrect label.
With this CL console will reevaluate expression with parentheses and if there is
no exceptions will output debug message for user "Reevaluating input as an
object literal.." and result object. Origin result with SyntaxError exception
will be output too.

BUG=499864
R=paulirish@chromium.org, pfeldman@chromium.org
==========

to

==========
[DevTools] Reevaluating input as object on SyntaxError Unexpected token :

If user evaluate in console expression like {a:1, b:2} then console will report
SyntaxError exception because this expression is interpreted as block scope
declaration with incorrect label.
With this CL console wrap all expressions that begins with { and ends with }. If
syntax error is occurred then we always reevaluate expression without
parentheses.

BUG=499864
R=paulirish@chromium.org, pfeldman@chromium.org
==========

[kozy, 2015-12-09 23:01:29]

Pavel, ptal.

[kozy, 2015-12-09 23:37:57]

Description was changed from

==========
[DevTools] Reevaluating input as object on SyntaxError Unexpected token :

If user evaluate in console expression like {a:1, b:2} then console will report
SyntaxError exception because this expression is interpreted as block scope
declaration with incorrect label.
With this CL console wrap all expressions that begins with { and ends with }. If
syntax error is occurred then we always reevaluate expression without
parentheses.

BUG=499864
R=paulirish@chromium.org, pfeldman@chromium.org
==========

to

==========
[DevTools] Evaluate expression like { ... } as Object Literal

If user evaluate in console expression like {a:1, b:2} then console will report
SyntaxError exception because this expression is interpreted as block scope
declaration with incorrect label.
With this CL console wrap all expressions that begins with { and ends with }.

BUG=499864
R=paulirish@chromium.org, pfeldman@chromium.org
==========

[kozy, 2015-12-09 23:43:03]

Silently add parentheses to expressions that starts with { and ends with }. The
same approach that nodejs uses.
ptal.

[pfeldman, 2015-12-10 02:35:35]

lgtm

[kozy, 2015-12-10 02:37:31]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2015-12-10 02:39:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1511043002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1511043002/80001

[commit-bot: I haz the power, 2015-12-10 03:27:34]

Description was changed from

==========
[DevTools] Evaluate expression like { ... } as Object Literal

If user evaluate in console expression like {a:1, b:2} then console will report
SyntaxError exception because this expression is interpreted as block scope
declaration with incorrect label.
With this CL console wrap all expressions that begins with { and ends with }.

BUG=499864
R=paulirish@chromium.org, pfeldman@chromium.org
==========

to

==========
[DevTools] Evaluate expression like { ... } as Object Literal

If user evaluate in console expression like {a:1, b:2} then console will report
SyntaxError exception because this expression is interpreted as block scope
declaration with incorrect label.
With this CL console wrap all expressions that begins with { and ends with }.

BUG=499864
R=paulirish@chromium.org, pfeldman@chromium.org
==========

[commit-bot: I haz the power, 2015-12-10 03:27:35]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-12-10 03:28:29]

Description was changed from

==========
[DevTools] Evaluate expression like { ... } as Object Literal

If user evaluate in console expression like {a:1, b:2} then console will report
SyntaxError exception because this expression is interpreted as block scope
declaration with incorrect label.
With this CL console wrap all expressions that begins with { and ends with }.

BUG=499864
R=paulirish@chromium.org, pfeldman@chromium.org
==========

to

==========
[DevTools] Evaluate expression like { ... } as Object Literal

If user evaluate in console expression like {a:1, b:2} then console will report
SyntaxError exception because this expression is interpreted as block scope
declaration with incorrect label.
With this CL console wrap all expressions that begins with { and ends with }.

BUG=499864
R=paulirish@chromium.org, pfeldman@chromium.org

Committed: https://crrev.com/4fd348fdb9c0b3842829acdfb2b82c86dacd8e0a
Cr-Commit-Position: refs/heads/master@{#364270}
==========

[commit-bot: I haz the power, 2015-12-10 03:28:30]

Patchset 5 (id:??) landed as
https://crrev.com/4fd348fdb9c0b3842829acdfb2b82c86dacd8e0a
Cr-Commit-Position: refs/heads/master@{#364270}