Extend Reader Mode animation time

Extend Reader Mode animation time

The animation between peeking and maximized states is too fast. This
change adds 200ms to that animation duraton.

BUG=570407
Committed: https://crrev.com/2040edbe49bb9dd7dc188607867136c048f9511e
Cr-Commit-Position: refs/heads/master@{#364428}

[mdjones, 2015-12-09 18:01:58]

mdjones@chromium.org changed reviewers:
+ pedrosimonetti@chromium.org, wychen@chromium.org

[mdjones, 2015-12-09 18:01:58]

PTAL

[wychen, 2015-12-09 19:46:09]

lgtm

[pedro (no code reviews), 2015-12-10 01:58:36]

lgtm

https://codereview.chromium.org/1511023003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/readermode/ReaderModePanel.java
(right):

https://codereview.chromium.org/1511023003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/readermode/ReaderModePanel.java:239:
protected void animatePanelToState(PanelState state, StateChangeReason reason,
long duration) {
I think it would be better to override the maximizePanel() method and pass a
custom duration to animatePanelToState(MAXIMIZED, reason, newDuration);

Also, have you checked with UX folks about this change in the duration? If you
haven't I would suggest doing that because it seems that a 418ms (218 + 200)
animation is too slow.

[mdjones, 2015-12-10 03:10:43]

https://codereview.chromium.org/1511023003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/readermode/ReaderModePanel.java
(right):

https://codereview.chromium.org/1511023003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/readermode/ReaderModePanel.java:239:
protected void animatePanelToState(PanelState state, StateChangeReason reason,
long duration) {
On 2015/12/10 01:58:36, pedrosimonetti wrote:
> I think it would be better to override the maximizePanel() method and pass a
> custom duration to animatePanelToState(MAXIMIZED, reason, newDuration);
> 
> Also, have you checked with UX folks about this change in the duration? If you
> haven't I would suggest doing that because it seems that a 418ms (218 + 200)
> animation is too slow.

UX said 150-200, I opted for 200 but changed it to 150 since that still looks
pretty good. Done.

[mdjones, 2015-12-10 18:43:29]

The CQ bit was checked by mdjones@chromium.org

[mdjones, 2015-12-10 18:43:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
pedrosimonetti@chromium.org, wychen@chromium.org
Link to the patchset: https://codereview.chromium.org/1511023003/#ps20001
(title: "override maximize panel instead")

[commit-bot: I haz the power, 2015-12-10 18:44:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1511023003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1511023003/20001

[commit-bot: I haz the power, 2015-12-10 19:40:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-10 19:41:57]

Description was changed from

==========
Extend Reader Mode animation time

The animation between peeking and maximized states is too fast. This
change adds 200ms to that animation duraton.

BUG=
==========

to

==========
Extend Reader Mode animation time

The animation between peeking and maximized states is too fast. This
change adds 200ms to that animation duraton.

BUG=

Committed: https://crrev.com/2040edbe49bb9dd7dc188607867136c048f9511e
Cr-Commit-Position: refs/heads/master@{#364428}
==========

[commit-bot: I haz the power, 2015-12-10 19:41:58]

Patchset 2 (id:??) landed as
https://crrev.com/2040edbe49bb9dd7dc188607867136c048f9511e
Cr-Commit-Position: refs/heads/master@{#364428}

[mdjones, 2015-12-16 19:32:33]

Description was changed from

==========
Extend Reader Mode animation time

The animation between peeking and maximized states is too fast. This
change adds 200ms to that animation duraton.

BUG=

Committed: https://crrev.com/2040edbe49bb9dd7dc188607867136c048f9511e
Cr-Commit-Position: refs/heads/master@{#364428}
==========

to

==========
Extend Reader Mode animation time

The animation between peeking and maximized states is too fast. This
change adds 200ms to that animation duraton.

BUG=570407

Committed: https://crrev.com/2040edbe49bb9dd7dc188607867136c048f9511e
Cr-Commit-Position: refs/heads/master@{#364428}
==========