Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3251)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/readermode/ReaderModePanel.java

Issue 1511023003: Extend Reader Mode animation time (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: override maximize panel instead Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/readermode/ReaderModePanel.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/readermode/ReaderModePanel.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/readermode/ReaderModePanel.java
index 3183df2ceea26fbd2c82ee13fbd9c6211e017ec6..a0f7c56e910eed19471caf64a79e173f8eb6eb33 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/readermode/ReaderModePanel.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/readermode/ReaderModePanel.java
@@ -236,6 +236,18 @@ public class ReaderModePanel extends OverlayPanel {
}
@Override
+ protected void maximizePanel(StateChangeReason reason) {
+ long duration = BASE_ANIMATION_DURATION_MS;
+ // Extend animation time when animating from PEEKED state to MAXIMIZED.
+ // TODO(mdjones): This check will be unnecessary after the expanded state is removed.
+ if (getPanelState() == PanelState.PEEKED) {
+ duration += 150;
+ }
+
+ super.animatePanelToState(PanelState.MAXIMIZED, reason, duration);
+ }
+
+ @Override
public float getArrowIconOpacity() {
// TODO(mdjones): This will not be needed once Reader Mode has its own scene layer.
// Never show the arrow icon.
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelAnimation.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698