third_party/WebKit/Source/core/layout/LayoutScrollbar.cpp - Issue 1511003003: Use refs for non-null GraphicsContext, Scrollbar, etc. in scrollbar related code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutScrollbar.cpp

Issue 1511003003: Use refs for non-null GraphicsContext, Scrollbar, etc. in scrollbar related code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ScrollbarRemove

Patch Set: yet another mac fix Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/shadow/SpinButtonElement.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutScrollbarPart.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutScrollbar.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutScrollbar.cpp b/third_party/WebKit/Source/core/layout/LayoutScrollbar.cpp

index f3016e76d1c3dcd71d0d22c6a0b8194fa6b0f6e7..1e819cb83f54f4ba42eebe80e8a6db16104c5aab 100644

--- a/third_party/WebKit/Source/core/layout/LayoutScrollbar.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutScrollbar.cpp

@@ -242,7 +242,7 @@ void LayoutScrollbar::updateScrollbarPart(ScrollbarPart partType, bool destroy)

if (needLayoutObject && partStyle->display() != BLOCK) {

// See if we are a button that should not be visible according to OS settings.

- ScrollbarButtonsPlacement buttonsPlacement = theme()->buttonsPlacement();

+ ScrollbarButtonsPlacement buttonsPlacement = theme().buttonsPlacement();

switch (partType) {

case BackButtonStartPart:

needLayoutObject = (buttonsPlacement == ScrollbarButtonsPlacementSingle || buttonsPlacement == ScrollbarButtonsPlacementDoubleStart