third_party/WebKit/Source/core/html/shadow/SpinButtonElement.cpp - Issue 1511003003: Use refs for non-null GraphicsContext, Scrollbar, etc. in scrollbar related code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/shadow/SpinButtonElement.cpp

Issue 1511003003: Use refs for non-null GraphicsContext, Scrollbar, etc. in scrollbar related code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ScrollbarRemove

Patch Set: yet another mac fix Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/VisualViewport.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutScrollbar.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/shadow/SpinButtonElement.cpp

diff --git a/third_party/WebKit/Source/core/html/shadow/SpinButtonElement.cpp b/third_party/WebKit/Source/core/html/shadow/SpinButtonElement.cpp

index d316b1827ed0ec03cd2a2cfb38ea34384e198ef4..718adbad396bb5545526bf1ea172949d251d8df2 100644

--- a/third_party/WebKit/Source/core/html/shadow/SpinButtonElement.cpp

+++ b/third_party/WebKit/Source/core/html/shadow/SpinButtonElement.cpp

@@ -216,8 +216,8 @@ bool SpinButtonElement::matchesReadWritePseudoClass() const

void SpinButtonElement::startRepeatingTimer()

{

m_pressStartingState = m_upDownState;

- ScrollbarTheme* theme = ScrollbarTheme::theme();

- m_repeatingTimer.start(theme->initialAutoscrollTimerDelay(), theme->autoscrollTimerDelay(), BLINK_FROM_HERE);

+ ScrollbarTheme& theme = ScrollbarTheme::theme();

+ m_repeatingTimer.start(theme.initialAutoscrollTimerDelay(), theme.autoscrollTimerDelay(), BLINK_FROM_HERE);

}

void SpinButtonElement::stopRepeatingTimer()