[Media Router] Add UMA metrics for Media Router Dialog WebUI performance.

[Media Router] Add UMA metrics for Media Router Dialog WebUI performance.

Adds two UMA metrics to track the duration of:
- Time between launch dialog intent to initial paint.
- Time between launch dialog intent to dialog data initialized in WebUI.

BUG=537263
Committed: https://crrev.com/a835647aa0938c6fbcf75eed2412bc57e090022f
Cr-Commit-Position: refs/heads/master@{#364422}

[apacible, 2015-12-08 03:27:02]

Description was changed from

==========
uma perf

BUG=
==========

to

==========
[Media Router] Add UMA metrics for Media Router Dialog WebUI performance.

BUG=537263
==========

[apacible, 2015-12-08 03:38:22]

Patchset #1 (id:1) has been deleted

[apacible, 2015-12-08 06:15:54]

Patchset #1 (id:20001) has been deleted

[apacible, 2015-12-09 01:05:06]

Patchset #2 (id:60001) has been deleted

[apacible, 2015-12-09 04:57:39]

Patchset #1 (id:40001) has been deleted

[apacible, 2015-12-09 16:41:12]

Description was changed from

==========
[Media Router] Add UMA metrics for Media Router Dialog WebUI performance.

BUG=537263
==========

to

==========
[Media Router] Add UMA metrics for Media Router Dialog WebUI performance.

Adds two UMA metrics to track the duration of:
- Time between launch dialog intent to initial paint.
- Time between launch dialog intent to dialog data initialized in WebUI.

BUG=537263
==========

[apacible, 2015-12-09 16:41:12]

apacible@chromium.org changed reviewers:
+ mfoltz@chromium.org

[apacible, 2015-12-09 16:47:59]

apacible@chromium.org changed reviewers:
+ isherman@chromium.org

[apacible, 2015-12-09 16:48:15]

PTAL, thanks!

[mark a. foltz, 2015-12-09 22:20:13]

LGTM

Some minor naming suggestions.

https://codereview.chromium.org/1510603003/diff/80001/chrome/browser/media/ro...
File chrome/browser/media/router/media_router_metrics.h (right):

https://codereview.chromium.org/1510603003/diff/80001/chrome/browser/media/ro...
chrome/browser/media/router/media_router_metrics.h:60: static void
RecordMediaRouterDialogInitialPaint(
Or maybe just "RecordMediaRouterDialogPaint".  If we want to record subsequent
rendering we can call them "Repaint."

https://codereview.chromium.org/1510603003/diff/80001/chrome/browser/media/ro...
chrome/browser/media/router/media_router_metrics.h:65: static void
RecordMediaRouterDialogInitializedWithData(
RecordMediaRouterDialogLoaded?

https://codereview.chromium.org/1510603003/diff/80001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl.cc
(right):

https://codereview.chromium.org/1510603003/diff/80001/chrome/browser/ui/webui...
chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl.cc:200:
base::Time dialog_creation_start_time = base::Time::Now();
dialog_creation_time?

https://codereview.chromium.org/1510603003/diff/80001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
(right):

https://codereview.chromium.org/1510603003/diff/80001/chrome/browser/ui/webui...
chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc:269:
media_router_ui_->OnUIInitiallyLoaded();
When is this called in the initialization flow?  It seems like we are capturing
some script execution time as well.  Does this happen after the top level
Polymer elements have been created for the default view?

[apacible, 2015-12-09 23:19:55]

https://codereview.chromium.org/1510603003/diff/80001/chrome/browser/media/ro...
File chrome/browser/media/router/media_router_metrics.h (right):

https://codereview.chromium.org/1510603003/diff/80001/chrome/browser/media/ro...
chrome/browser/media/router/media_router_metrics.h:60: static void
RecordMediaRouterDialogInitialPaint(
On 2015/12/09 22:20:13, mark a. foltz wrote:
> Or maybe just "RecordMediaRouterDialogPaint".  If we want to record subsequent
> rendering we can call them "Repaint."

Done. Also updated histogram name.

https://codereview.chromium.org/1510603003/diff/80001/chrome/browser/media/ro...
chrome/browser/media/router/media_router_metrics.h:65: static void
RecordMediaRouterDialogInitializedWithData(
On 2015/12/09 22:20:13, mark a. foltz wrote:
> RecordMediaRouterDialogLoaded?

Done. Also updated histogram name.

https://codereview.chromium.org/1510603003/diff/80001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl.cc
(right):

https://codereview.chromium.org/1510603003/diff/80001/chrome/browser/ui/webui...
chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl.cc:200:
base::Time dialog_creation_start_time = base::Time::Now();
On 2015/12/09 22:20:13, mark a. foltz wrote:
> dialog_creation_time?

Done.

https://codereview.chromium.org/1510603003/diff/80001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
(right):

https://codereview.chromium.org/1510603003/diff/80001/chrome/browser/ui/webui...
chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc:269:
media_router_ui_->OnUIInitiallyLoaded();
On 2015/12/09 22:20:13, mark a. foltz wrote:
> When is this called in the initialization flow?  It seems like we are
capturing
> some script execution time as well.  Does this happen after the top level
> Polymer elements have been created for the default view?

This is called ASAP when the WebUI finishes loading.

The flow looks like:
1. User action to open dialog.
2. Dialog created (not shown yet).
3. WebUI page loads ('load' event fired).
4. 'load' event triggers initialize().
5. initialize() immediately calls requestInitialData()
6. requestInitialData() immediately calls OnRequestInitialData() here.
7. OnRequestInitialData() immediately calls OnUIInitiallyLoaded(). <- log here

I previously added some logging to look at initialization flow (not included in
the CL since it was just for sanity checks) and the page loading includes the
creation of the Polymer elements.

[Ilya Sherman, 2015-12-10 04:48:56]

metrics lgtm

https://codereview.chromium.org/1510603003/diff/100001/chrome/browser/media/r...
File chrome/browser/media/router/media_router_metrics.h (right):

https://codereview.chromium.org/1510603003/diff/100001/chrome/browser/media/r...
chrome/browser/media/router/media_router_metrics.h:61: const base::TimeDelta&
delta);
nit: I think that TimeDelta is typically passed by copy, since it's just an
int64.

[apacible, 2015-12-10 17:22:18]

https://codereview.chromium.org/1510603003/diff/100001/chrome/browser/media/r...
File chrome/browser/media/router/media_router_metrics.h (right):

https://codereview.chromium.org/1510603003/diff/100001/chrome/browser/media/r...
chrome/browser/media/router/media_router_metrics.h:61: const base::TimeDelta&
delta);
On 2015/12/10 04:48:55, Ilya Sherman wrote:
> nit: I think that TimeDelta is typically passed by copy, since it's just an
> int64.

Done.

[apacible, 2015-12-10 19:07:26]

The CQ bit was checked by apacible@chromium.org

[apacible, 2015-12-10 19:07:28]

The patchset sent to the CQ was uploaded after l-g-t-m from mfoltz@chromium.org,
isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/1510603003/#ps140001
(title: "Rebase.")

[commit-bot: I haz the power, 2015-12-10 19:11:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1510603003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1510603003/140001

[commit-bot: I haz the power, 2015-12-10 19:20:51]

Description was changed from

==========
[Media Router] Add UMA metrics for Media Router Dialog WebUI performance.

Adds two UMA metrics to track the duration of:
- Time between launch dialog intent to initial paint.
- Time between launch dialog intent to dialog data initialized in WebUI.

BUG=537263
==========

to

==========
[Media Router] Add UMA metrics for Media Router Dialog WebUI performance.

Adds two UMA metrics to track the duration of:
- Time between launch dialog intent to initial paint.
- Time between launch dialog intent to dialog data initialized in WebUI.

BUG=537263
==========

[commit-bot: I haz the power, 2015-12-10 19:20:52]

Committed patchset #4 (id:140001)

[commit-bot: I haz the power, 2015-12-10 19:21:54]

Description was changed from

==========
[Media Router] Add UMA metrics for Media Router Dialog WebUI performance.

Adds two UMA metrics to track the duration of:
- Time between launch dialog intent to initial paint.
- Time between launch dialog intent to dialog data initialized in WebUI.

BUG=537263
==========

to

==========
[Media Router] Add UMA metrics for Media Router Dialog WebUI performance.

Adds two UMA metrics to track the duration of:
- Time between launch dialog intent to initial paint.
- Time between launch dialog intent to dialog data initialized in WebUI.

BUG=537263

Committed: https://crrev.com/a835647aa0938c6fbcf75eed2412bc57e090022f
Cr-Commit-Position: refs/heads/master@{#364422}
==========

[commit-bot: I haz the power, 2015-12-10 19:21:55]

Patchset 4 (id:??) landed as
https://crrev.com/a835647aa0938c6fbcf75eed2412bc57e090022f
Cr-Commit-Position: refs/heads/master@{#364422}