Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4060)

Unified Diff: chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl.cc

Issue 1510603003: [Media Router] Add UMA metrics for Media Router Dialog WebUI performance. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl.cc
diff --git a/chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl.cc b/chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl.cc
index 16a2ba2650a2ba891600a621e272bfc051e14322..138ae3ea1ee451a2070125a0b5542bd92fbd89b7 100644
--- a/chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl.cc
+++ b/chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl.cc
@@ -197,6 +197,7 @@ void MediaRouterDialogControllerImpl::CloseMediaRouterDialog() {
void MediaRouterDialogControllerImpl::CreateMediaRouterDialog() {
DCHECK(!dialog_observer_.get());
+ base::Time dialog_creation_time = base::Time::Now();
TRACE_EVENT_NESTABLE_ASYNC_BEGIN0("media_router", "UI", initiator());
Profile* profile =
@@ -232,6 +233,15 @@ void MediaRouterDialogControllerImpl::CreateMediaRouterDialog() {
"WebContents created",
media_router_dialog);
+ // |media_router_ui| is created when |constrained_delegate| is created.
+ // For tests, GetWebUI() returns a nullptr.
+ if (media_router_dialog->GetWebUI()) {
+ MediaRouterUI* media_router_ui = static_cast<MediaRouterUI*>(
+ media_router_dialog->GetWebUI()->GetController());
+ DCHECK(media_router_ui);
+ media_router_ui->SetUIInitializationTimer(dialog_creation_time);
+ }
+
media_router_dialog_pending_ = true;
dialog_observer_.reset(new DialogWebContentsObserver(

Powered by Google App Engine
This is Rietveld 408576698