Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 1510493013: [Android] Suppress findbugs hardcoded filename warning. (Closed)

Created:
5 years ago by mikecase (-- gone --)
Modified:
5 years ago
Reviewers:
nyquist, jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, mikecase+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Suppress findbugs hardcoded filename warning. We use a hardcoded file to determine timeout scaling. Suppressing findbugs warning about using the hardcoded filename in the OnDeviceInstrumentationDriver class. BUG= TBR=nyquist@chromium.org Committed: https://crrev.com/a25128084bd5061934fd5c0f9730817f304ad8a4 Cr-Commit-Position: refs/heads/master@{#364483}

Patch Set 1 #

Patch Set 2 : Need to add base_java to BUILD.gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M testing/android/driver/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M testing/android/driver/java/src/org/chromium/test/driver/OnDeviceInstrumentationDriver.java View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1510493013/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1510493013/1
5 years ago (2015-12-10 19:24:08 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/152295)
5 years ago (2015-12-10 19:46:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1510493013/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1510493013/20001
5 years ago (2015-12-10 19:59:16 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-10 21:31:00 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-10 21:32:24 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a25128084bd5061934fd5c0f9730817f304ad8a4
Cr-Commit-Position: refs/heads/master@{#364483}

Powered by Google App Engine
This is Rietveld 408576698