Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: testing/android/driver/java/src/org/chromium/test/driver/OnDeviceInstrumentationDriver.java

Issue 1510493013: [Android] Suppress findbugs hardcoded filename warning. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Need to add base_java to BUILD.gn Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « testing/android/driver/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: testing/android/driver/java/src/org/chromium/test/driver/OnDeviceInstrumentationDriver.java
diff --git a/testing/android/driver/java/src/org/chromium/test/driver/OnDeviceInstrumentationDriver.java b/testing/android/driver/java/src/org/chromium/test/driver/OnDeviceInstrumentationDriver.java
index f9b31b03e97830f1f162fdeeb93b7bbea7282ef9..1003e6a76b7283f53fa571027c9f88f04e12386a 100644
--- a/testing/android/driver/java/src/org/chromium/test/driver/OnDeviceInstrumentationDriver.java
+++ b/testing/android/driver/java/src/org/chromium/test/driver/OnDeviceInstrumentationDriver.java
@@ -13,6 +13,7 @@ import android.os.Environment;
import android.test.InstrumentationTestRunner;
import android.util.Log;
+import org.chromium.base.annotations.SuppressFBWarnings;
import org.chromium.base.test.util.ScalableTimeout;
import org.chromium.test.broker.OnDeviceInstrumentationBroker;
import org.chromium.test.reporter.TestStatusReceiver;
@@ -66,6 +67,7 @@ public class OnDeviceInstrumentationDriver extends Instrumentation {
@param arguments The arguments to parse.
*/
@Override
+ @SuppressFBWarnings("DMI_HARDCODED_ABSOLUTE_FILENAME")
public void onCreate(Bundle arguments) {
mTargetArgs = new Bundle(arguments);
mTargetPackage = arguments.getString(EXTRA_TARGET_PACKAGE);
@@ -145,6 +147,7 @@ public class OnDeviceInstrumentationDriver extends Instrumentation {
/** Clean up the reporting service. */
@Override
+ @SuppressFBWarnings("DMI_HARDCODED_ABSOLUTE_FILENAME")
public void onDestroy() {
super.onDestroy();
if (mTimeoutScale != null) {
« no previous file with comments | « testing/android/driver/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698