Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1510493011: MIPS: Fix [runtime] [proxy] implement [[Construct]]. (Closed)

Created:
5 years ago by paul.l...
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix [runtime] [proxy] implement [[Construct]]. Avoid overwrite of instance type while checking IsCallable() (t2->t3). Also slightly optimize push of register pair. TEST=mjsunit/harmony/proxies-construct BUG= Committed: https://crrev.com/aa5eb1e0ed4709e3e417dd7ce77112626378cb3a Cr-Commit-Position: refs/heads/master@{#32736}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M src/mips/builtins-mips.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
paul.l...
PTAL.
5 years ago (2015-12-10 05:33:24 UTC) #2
akos.palfi.imgtec
Lgtm
5 years ago (2015-12-10 07:12:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1510493011/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1510493011/1
5 years ago (2015-12-10 07:13:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 07:32:41 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-10 07:33:29 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aa5eb1e0ed4709e3e417dd7ce77112626378cb3a
Cr-Commit-Position: refs/heads/master@{#32736}

Powered by Google App Engine
This is Rietveld 408576698