Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1152)

Unified Diff: src/mips/builtins-mips.cc

Issue 1510493011: MIPS: Fix [runtime] [proxy] implement [[Construct]]. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/mips64/builtins-mips64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/mips/builtins-mips.cc
diff --git a/src/mips/builtins-mips.cc b/src/mips/builtins-mips.cc
index f106a43a6ec2c8bca03fdb67a0eb47cce0a35666..a393f2c4098ada8b4479b0de64d9409e7f8b0090 100644
--- a/src/mips/builtins-mips.cc
+++ b/src/mips/builtins-mips.cc
@@ -1762,8 +1762,7 @@ void Builtins::Generate_ConstructProxy(MacroAssembler* masm) {
// -----------------------------------
// Call into the Runtime for Proxy [[Construct]].
- __ Push(a1);
- __ Push(a3);
+ __ Push(a1, a3);
// Include the pushed new_target, constructor and the receiver.
__ Addu(a0, a0, Operand(3));
// Tail-call to the runtime.
@@ -1792,9 +1791,9 @@ void Builtins::Generate_Construct(MacroAssembler* masm) {
RelocInfo::CODE_TARGET, eq, t2, Operand(JS_FUNCTION_TYPE));
// Check if target has a [[Construct]] internal method.
- __ lbu(t2, FieldMemOperand(t1, Map::kBitFieldOffset));
- __ And(t2, t2, Operand(1 << Map::kIsCallable));
- __ Branch(&non_constructor, eq, t2, Operand(zero_reg));
+ __ lbu(t3, FieldMemOperand(t1, Map::kBitFieldOffset));
+ __ And(t3, t3, Operand(1 << Map::kIsCallable));
+ __ Branch(&non_constructor, eq, t3, Operand(zero_reg));
// Only dispatch to proxies after checking whether they are constructors.
__ Jump(masm->isolate()->builtins()->ConstructProxy(), RelocInfo::CODE_TARGET,
« no previous file with comments | « no previous file | src/mips64/builtins-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698