Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 151043002: Remove SVGDocument from bindings generator and test cases (Closed)

Created:
6 years, 10 months ago by Nils Barth (inactive)
Modified:
6 years, 10 months ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, watchdog-blink-watchlist_google.com, Inactive, kouhei (in TOK), rwlbuis, pdr.
Visibility:
Public.

Description

Remove SVGDocument from bindings generator and test cases Bindings generator side to: Remove SVGDocument binding https://codereview.chromium.org/146193003 SVGDocument no longer exists as an interface, so the test case that uses it broke, and can be removed. Using real interfaces in test IDL files means changes to real IDL files can break run-bindings-tests. This is ok (we're not going to run r-b-t on every IDL edit! and it's easy to fix), but something to be aware of. It also was hard-coded as inheriting from Node in the CG, which we can remove. BUG=238366 TBR=haraken NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166182

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -27 lines) Patch
M Source/bindings/scripts/code_generator_v8.pm View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/tests/idls/TestSVG.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestSVG.cpp View 3 chunks +0 lines, -25 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Nils Barth (inactive)
FYI: fixing run-bindings-tests in presubmit script; broken by changes in real IDL file.
6 years, 10 months ago (2014-01-31 01:25:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/151043002/1
6 years, 10 months ago (2014-01-31 01:27:11 UTC) #2
commit-bot: I haz the power
Change committed as 166182
6 years, 10 months ago (2014-01-31 01:27:54 UTC) #3
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 01:27:58 UTC) #4
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 01:28:06 UTC) #5
haraken
6 years, 10 months ago (2014-01-31 01:38:05 UTC) #6
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698