Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1510343002: Add WebrtcConnectionToClient. (Closed)

Created:
5 years ago by Sergey Ulanov
Modified:
5 years ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@webrtc_thread
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add WebrtcConnectionToClient. The new WebrtcConnectionToClient implements ConnectionToClient for WebRTC-based protocol. BUG=547158 Committed: https://crrev.com/0fc40f9403a782b6fb01237fd1fe9d730e1206b2 Cr-Commit-Position: refs/heads/master@{#364409}

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+439 lines, -39 lines) Patch
M remoting/protocol/BUILD.gn View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M remoting/protocol/ice_connection_to_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/protocol/jingle_session.cc View 1 chunk +2 lines, -1 line 0 comments Download
M remoting/protocol/transport.h View 3 chunks +14 lines, -0 lines 0 comments Download
M remoting/protocol/transport.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M remoting/protocol/video_stream.h View 1 chunk +2 lines, -0 lines 0 comments Download
A + remoting/protocol/webrtc_connection_to_client.h View 3 chunks +11 lines, -32 lines 0 comments Download
A remoting/protocol/webrtc_connection_to_client.cc View 1 1 chunk +203 lines, -0 lines 0 comments Download
A remoting/protocol/webrtc_connection_to_client_unittest.cc View 1 chunk +95 lines, -0 lines 0 comments Download
M remoting/protocol/webrtc_transport.h View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/protocol/webrtc_transport.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M remoting/protocol/webrtc_video_capturer_adapter.cc View 3 chunks +2 lines, -2 lines 0 comments Download
A remoting/protocol/webrtc_video_stream.h View 1 chunk +44 lines, -0 lines 0 comments Download
A remoting/protocol/webrtc_video_stream.cc View 1 chunk +49 lines, -0 lines 0 comments Download
M remoting/remoting_srcs.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
M remoting/remoting_test.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (7 generated)
Sergey Ulanov
5 years ago (2015-12-09 20:10:28 UTC) #3
Jamie
lgtm
5 years ago (2015-12-09 23:15:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1510343002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1510343002/40001
5 years ago (2015-12-10 02:12:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/41333)
5 years ago (2015-12-10 02:53:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1510343002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1510343002/60001
5 years ago (2015-12-10 17:33:27 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years ago (2015-12-10 18:42:50 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-10 18:43:46 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0fc40f9403a782b6fb01237fd1fe9d730e1206b2
Cr-Commit-Position: refs/heads/master@{#364409}

Powered by Google App Engine
This is Rietveld 408576698