Cleanups in WebrtcTransport.

Cleanups in WebrtcTransport.

This change includes several changes needed in the Webrtc-based
transport:
1. WebrtcTransportFactory no longer owns the worker thread. Instead
   the calling code must provide a thread that has been started already.
   This also allows to make WebrtcTransport::Start() synchronous.
2. The direction in which offer and answer is sent is reversed. The
   host sends offer to the client and the client replies with an answer.
3. Offer is generated only after OnRenegotiationNeeded() notification is
   received.
4. The |is_server| flag in WebrtcDataStreamAdapter is replaced with
   |outgoing|, so connections may be created in either direction.

BUG=547158
Committed: https://crrev.com/10ffce873cf392b9d48a28fe1282f42f33b28e96
Cr-Commit-Position: refs/heads/master@{#364155}

[Sergey Ulanov, 2015-12-09 19:09:54]

Description was changed from

==========
Cleanups in WebrtcTransport.

This change includes several changes needed in the Webrtc-based
transport:
1. WebrtcTransportFactory no longer owns the worker thread. Instead
   the calling code must provide a thread that has been started already.
   This also allows to make WebrtcTransport::Start() synchronous.
2. The direction in which offer and answer is sent is reversed. The
   host sends offer to the client and the client replies with an answer.
3. The |is_server| flag in WebrtcDataStreamAdapter is replaced with
   |outgoing|, so connections may be created in either direction.

BUG=547158
==========

to

==========
Cleanups in WebrtcTransport.

This change includes several changes needed in the Webrtc-based
transport:
1. WebrtcTransportFactory no longer owns the worker thread. Instead
   the calling code must provide a thread that has been started already.
   This also allows to make WebrtcTransport::Start() synchronous.
2. The direction in which offer and answer is sent is reversed. The
   host sends offer to the client and the client replies with an answer.
3. Offer is generated only after OnRenegotiationNeeded() notification is
   received.
4. The |is_server| flag in WebrtcDataStreamAdapter is replaced with
   |outgoing|, so connections may be created in either direction.

BUG=547158
==========

[Sergey Ulanov, 2015-12-09 19:09:54]

sergeyu@chromium.org changed reviewers:
+ jamiewalch@chromium.org

[Jamie, 2015-12-09 19:42:23]

lgtm

https://codereview.chromium.org/1510333002/diff/1/remoting/protocol/webrtc_tr...
File remoting/protocol/webrtc_transport.cc (right):

https://codereview.chromium.org/1510333002/diff/1/remoting/protocol/webrtc_tr...
remoting/protocol/webrtc_transport.cc:137: webrtc::FakeConstraints constraints;
Unrelated to this CL, but why are we using FakeConstraints in non-test code?

[Sergey Ulanov, 2015-12-09 19:57:06]

https://codereview.chromium.org/1510333002/diff/1/remoting/protocol/webrtc_tr...
File remoting/protocol/webrtc_transport.cc (right):

https://codereview.chromium.org/1510333002/diff/1/remoting/protocol/webrtc_tr...
remoting/protocol/webrtc_transport.cc:137: webrtc::FakeConstraints constraints;
On 2015/12/09 19:42:22, Jamie wrote:
> Unrelated to this CL, but why are we using FakeConstraints in non-test code?

PeerConnection gets MediaConstraintsInterface. FakeConstraints is the only
implementation of that interface that we have available. Examples use
FakeConstraints. I think it should be just renamed to something else. There is
nothing fake about it. It just stores the constraints in memory. I'm not sure
why we even need abstract interface for constraints.

[Sergey Ulanov, 2015-12-09 19:57:18]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2015-12-09 19:59:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1510333002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1510333002/1

[commit-bot: I haz the power, 2015-12-09 21:12:10]

Description was changed from

==========
Cleanups in WebrtcTransport.

This change includes several changes needed in the Webrtc-based
transport:
1. WebrtcTransportFactory no longer owns the worker thread. Instead
   the calling code must provide a thread that has been started already.
   This also allows to make WebrtcTransport::Start() synchronous.
2. The direction in which offer and answer is sent is reversed. The
   host sends offer to the client and the client replies with an answer.
3. Offer is generated only after OnRenegotiationNeeded() notification is
   received.
4. The |is_server| flag in WebrtcDataStreamAdapter is replaced with
   |outgoing|, so connections may be created in either direction.

BUG=547158
==========

to

==========
Cleanups in WebrtcTransport.

This change includes several changes needed in the Webrtc-based
transport:
1. WebrtcTransportFactory no longer owns the worker thread. Instead
   the calling code must provide a thread that has been started already.
   This also allows to make WebrtcTransport::Start() synchronous.
2. The direction in which offer and answer is sent is reversed. The
   host sends offer to the client and the client replies with an answer.
3. Offer is generated only after OnRenegotiationNeeded() notification is
   received.
4. The |is_server| flag in WebrtcDataStreamAdapter is replaced with
   |outgoing|, so connections may be created in either direction.

BUG=547158
==========

[commit-bot: I haz the power, 2015-12-09 21:12:13]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-09 21:13:03]

Description was changed from

==========
Cleanups in WebrtcTransport.

This change includes several changes needed in the Webrtc-based
transport:
1. WebrtcTransportFactory no longer owns the worker thread. Instead
   the calling code must provide a thread that has been started already.
   This also allows to make WebrtcTransport::Start() synchronous.
2. The direction in which offer and answer is sent is reversed. The
   host sends offer to the client and the client replies with an answer.
3. Offer is generated only after OnRenegotiationNeeded() notification is
   received.
4. The |is_server| flag in WebrtcDataStreamAdapter is replaced with
   |outgoing|, so connections may be created in either direction.

BUG=547158
==========

to

==========
Cleanups in WebrtcTransport.

This change includes several changes needed in the Webrtc-based
transport:
1. WebrtcTransportFactory no longer owns the worker thread. Instead
   the calling code must provide a thread that has been started already.
   This also allows to make WebrtcTransport::Start() synchronous.
2. The direction in which offer and answer is sent is reversed. The
   host sends offer to the client and the client replies with an answer.
3. Offer is generated only after OnRenegotiationNeeded() notification is
   received.
4. The |is_server| flag in WebrtcDataStreamAdapter is replaced with
   |outgoing|, so connections may be created in either direction.

BUG=547158

Committed: https://crrev.com/10ffce873cf392b9d48a28fe1282f42f33b28e96
Cr-Commit-Position: refs/heads/master@{#364155}
==========

[commit-bot: I haz the power, 2015-12-09 21:13:03]

Patchset 1 (id:??) landed as
https://crrev.com/10ffce873cf392b9d48a28fe1282f42f33b28e96
Cr-Commit-Position: refs/heads/master@{#364155}