a few minor tweaks the bookmarks API:...

a few minor tweaks the bookmarks API:
* change name "childrenIds" to "children"
* add dateAdded and dateGroupModified properties
* add id to onRemoved

BUG=13994
BUG=14581
BUG=12217
TEST=load sample bookmarks extension and play around with Dump Bookmarks



Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19536

[Matt Perry, 2009-06-29 21:00:36]

http://codereview.chromium.org/151032/diff/10/16
File chrome/renderer/resources/extension_process_bindings.js (right):

http://codereview.chromium.org/151032/diff/10/16#newcode506
Line 506: // Sends (id, {title, url, parentId, index, dateAdded,
|dateGroupModified|})
what does |foo| mean?

http://codereview.chromium.org/151032/diff/10/16#newcode506
Line 506: // Sends (id, {title, url, parentId, index, dateAdded,
|dateGroupModified|})
also, fyi it looks like the second param also includes an 'id' property.  Kinda
weird that it's duplicated as the first param.

http://codereview.chromium.org/151032/diff/10/16#newcode506
Line 506: // Sends (id, {title, url, parentId, index, dateAdded,
|dateGroupModified|})
also, maybe add a note explaining the format dateAdded comes in? I'm unclear
myself on why you did (time * 1000).

[Erik does not do reviews, 2009-06-29 21:23:21]

new snap uploaded

http://codereview.chromium.org/151032/diff/10/16
File chrome/renderer/resources/extension_process_bindings.js (right):

http://codereview.chromium.org/151032/diff/10/16#newcode506
Line 506: // Sends (id, {title, url, parentId, index, dateAdded,
|dateGroupModified|})
On 2009/06/29 21:00:36, Matt Perry wrote:
> also, fyi it looks like the second param also includes an 'id' property. 
Kinda
> weird that it's duplicated as the first param.

yeah, that's not intentional.

http://codereview.chromium.org/151032/diff/10/16#newcode506
Line 506: // Sends (id, {title, url, parentId, index, dateAdded,
|dateGroupModified|})
On 2009/06/29 21:00:36, Matt Perry wrote:
> what does |foo| mean?

optional.  wasn't sure how to express that.  I took it out since some other
parameters are optional as well (url isn't present for folders).

http://codereview.chromium.org/151032/diff/10/16#newcode506
Line 506: // Sends (id, {title, url, parentId, index, dateAdded,
|dateGroupModified|})
On 2009/06/29 21:00:36, Matt Perry wrote:
> also, maybe add a note explaining the format dateAdded comes in? I'm unclear
> myself on why you did (time * 1000).

It's milliseconds since the UTC epoch, which is what Date expects in its
constructor.  I added a comment.

[Matt Perry, 2009-06-29 21:28:07]

LGTM

http://codereview.chromium.org/151032/diff/1019/1025
File chrome/renderer/resources/extension_process_bindings.js (right):

http://codereview.chromium.org/151032/diff/1019/1025#newcode506
Line 506: // Sends (id, {title, url, parentId, index, dateAdded,
dateGroupModified})
btw, the convention for optional is [foo] - see [childrenIds] below.

[Erik does not do reviews, 2009-06-29 21:30:00]

http://codereview.chromium.org/151032/diff/1019/1025
File chrome/renderer/resources/extension_process_bindings.js (right):

http://codereview.chromium.org/151032/diff/1019/1025#newcode506
Line 506: // Sends (id, {title, url, parentId, index, dateAdded,
dateGroupModified})
On 2009/06/29 21:28:07, Matt Perry wrote:
> btw, the convention for optional is [foo] - see [childrenIds] below.

normally, I'd agree, but in this case, [] indicates array/list.

[Matt Perry, 2009-06-29 21:30:50]

http://codereview.chromium.org/151032/diff/1019/1025
File chrome/renderer/resources/extension_process_bindings.js (right):

http://codereview.chromium.org/151032/diff/1019/1025#newcode506
Line 506: // Sends (id, {title, url, parentId, index, dateAdded,
dateGroupModified})
On 2009/06/29 21:30:00, Erik Kay wrote:
> On 2009/06/29 21:28:07, Matt Perry wrote:
> > btw, the convention for optional is [foo] - see [childrenIds] below.
> 
> normally, I'd agree, but in this case, [] indicates array/list.
> 

oh right.. that's unfortunate :(