Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2285)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/renderer/resources/extension_process_bindings.js

Issue 151032: a few minor tweaks the bookmarks API:... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_bookmarks_module_constants.cc ('k') | chrome/test/data/extensions/samples/bookmarks/bookmark_view.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/resources/extension_process_bindings.js
===================================================================
--- chrome/renderer/resources/extension_process_bindings.js (revision 19487)
+++ chrome/renderer/resources/extension_process_bindings.js (working copy)
@@ -503,10 +503,11 @@
// bookmark events
- // Sends (id, {title, url, parentId, index})
+ // Sends (id, {title, url, parentId, index, dateAdded, dateGroupModified})
Matt Perry 2009/06/29 21:28:07 btw, the convention for optional is [foo] - see [c
Erik does not do reviews 2009/06/29 21:30:00 normally, I'd agree, but in this case, [] indicate
Matt Perry 2009/06/29 21:30:50 oh right.. that's unfortunate :(
+ // date values are milliseconds since the UTC epoch.
chrome.bookmarks.onAdded = new chrome.Event("bookmark-added");
- // Sends ({parentId, index})
+ // Sends (id, {parentId, index})
chrome.bookmarks.onRemoved = new chrome.Event("bookmark-removed");
// Sends (id, object) where object has list of properties that have changed.
« no previous file with comments | « chrome/browser/extensions/extension_bookmarks_module_constants.cc ('k') | chrome/test/data/extensions/samples/bookmarks/bookmark_view.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698