Issue 15102006: BinaryOpStub::GenerateSmiStub() on 32bit would erroneously patch the IC in case of a gc requirement…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15102006: BinaryOpStub::GenerateSmiStub() on 32bit would erroneously patch the IC in case of a gc requirement… (Closed)

Created:
7 years, 7 months ago by mvstanton

Modified:
7 years, 7 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

BinaryOpStub::GenerateSmiStub() on 32bit would erroneously patch the IC in case of a gc requirement. Brought the behavior into line with ARM and x64. Also some cleanup to label names. BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14653

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -1 line)			Patch
	M	src/ia32/code-stubs-ia32.cc	View	1 2	2 chunks	+24 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

mvstanton

Hi Jakob, if you could take a look at this cleanup CL. It is in ...

7 years, 7 months ago (2013-05-13 14:20:35 UTC) #1

Jakob Kummerow

LGTM. Since the x64 change is merely a renaming, and I can't decide whether I ...

7 years, 7 months ago (2013-05-13 15:30:58 UTC) #2

mvstanton

7 years, 7 months ago (2013-05-14 06:53:54 UTC) #3

Message was sent while issue was closed.

Committed patchset #4 manually as r14653 (presubmit successful).