Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 1509733003: Disable sanitizers with a blacklist. (Closed)

Created:
5 years ago by mtklein_C
Modified:
5 years ago
Reviewers:
herb_g
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Disable sanitizers with a blacklist. We think this might be more flexible. It allows, e.g, function-level blacklisting, and here an easy one-stop-shop blacklist for all of third_party/externals. BUG=skia: CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-ASAN-Trybot NOTREECHECKS=true Committed: https://skia.googlesource.com/skia/+/bb5b77db51d2e149ee66db284903572a5aac09be

Patch Set 1 #

Patch Set 2 : missing #

Patch Set 3 : quote paths #

Patch Set 4 : try relativization another way #

Patch Set 5 : try split #

Patch Set 6 : python to the rescue #

Patch Set 7 : no comments for now #

Patch Set 8 : danger comments #

Patch Set 9 : note #

Patch Set 10 : need leading #

Patch Set 11 : simpler #

Patch Set 12 : put yasm stuff back #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -5 lines) Patch
M gyp/common_conditions.gypi View 1 2 3 4 5 1 chunk +4 lines, -2 lines 0 comments Download
M gyp/common_variables.gypi View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M gyp/sfntly.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
A tools/xsan.blacklist View 1 2 3 4 5 6 7 8 9 10 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
mtklein_C
5 years ago (2015-12-08 20:31:01 UTC) #3
herb_g
lgtm
5 years ago (2015-12-08 22:08:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1509733003/220001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1509733003/220001
5 years ago (2015-12-08 22:08:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1509733003/220001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1509733003/220001
5 years ago (2015-12-08 22:09:20 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-08 22:26:20 UTC) #12
Message was sent while issue was closed.
Committed patchset #12 (id:220001) as
https://skia.googlesource.com/skia/+/bb5b77db51d2e149ee66db284903572a5aac09be

Powered by Google App Engine
This is Rietveld 408576698