Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1402)

Unified Diff: gyp/common_conditions.gypi

Issue 1509733003: Disable sanitizers with a blacklist. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: put yasm stuff back Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gyp/common_variables.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gyp/common_conditions.gypi
diff --git a/gyp/common_conditions.gypi b/gyp/common_conditions.gypi
index 7a03f64a7ecf09d9886e7519ff0c5cc7cb814117..ddfd1d300a1ebfd918c98a6afb30b8fde37e8333 100644
--- a/gyp/common_conditions.gypi
+++ b/gyp/common_conditions.gypi
@@ -435,8 +435,10 @@
# Enable asan, tsan, etc.
[ 'skia_sanitizer', {
'cflags': [
- '-fsanitize=<(skia_sanitizer)',
- '-fno-sanitize-recover=<(skia_sanitizer)',
+ '-fsanitize=<(skia_sanitizer)', # Turn on sanitizers.
+ '-fno-sanitize-recover=<(skia_sanitizer)', # Make any failure fatal.
+ '-fsanitize-blacklist=<(skia_sanitizer_blacklist)', # Compile in our blacklist.
+ '-include <(skia_sanitizer_blacklist)', # Make every .cpp depend on it.
],
'ldflags': [
'-fsanitize=<(skia_sanitizer)',
« no previous file with comments | « no previous file | gyp/common_variables.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698