Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: Source/core/rendering/svg/RenderSVGResourceFilter.cpp

Issue 150973004: Fixes the rendering of a SVG filter (e.g. feFlood) by testing against total (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/svg/RenderSVGResourceFilter.cpp
diff --git a/Source/core/rendering/svg/RenderSVGResourceFilter.cpp b/Source/core/rendering/svg/RenderSVGResourceFilter.cpp
index 1473c5f95392ca5e1cde99719bf8ebaf0536fd39..d6038848486b650aec993118d484a0a0a06055db 100644
--- a/Source/core/rendering/svg/RenderSVGResourceFilter.cpp
+++ b/Source/core/rendering/svg/RenderSVGResourceFilter.cpp
@@ -110,12 +110,12 @@ PassRefPtr<SVGFilterBuilder> RenderSVGResourceFilter::buildPrimitives(SVGFilter*
bool RenderSVGResourceFilter::fitsInMaximumImageSize(const FloatSize& size, FloatSize& scale)
Stephen Chennney 2014/02/11 14:47:21 The current implementation is wrong. It should com
{
bool matchesFilterSize = true;
- if (size.width() * scale.width() > kMaxFilterSize) {
- scale.setWidth(kMaxFilterSize / size.width());
+ if (size.width() * scale.width() > FilterEffect::maxFilterArea()) {
fs 2014/02/07 10:17:51 This compares a distance to an area.
+ scale.setWidth(FilterEffect::maxFilterArea() / size.width());
matchesFilterSize = false;
}
- if (size.height() * scale.height() > kMaxFilterSize) {
- scale.setHeight(kMaxFilterSize / size.height());
+ if (size.height() * scale.height() > FilterEffect::maxFilterArea()) {
fs 2014/02/07 10:17:51 Same as above.
+ scale.setHeight(FilterEffect::maxFilterArea() / size.height());
matchesFilterSize = false;
}

Powered by Google App Engine
This is Rietveld 408576698