Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: Source/platform/graphics/filters/FilterEffect.h

Issue 150973004: Fixes the rendering of a SVG filter (e.g. feFlood) by testing against total (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/graphics/filters/FilterEffect.h
diff --git a/Source/platform/graphics/filters/FilterEffect.h b/Source/platform/graphics/filters/FilterEffect.h
index 8e4c351797b89e23242f9b4739f65183519eb87e..bd02fc01ca9aa81c5530bed974c54528ba486559 100644
--- a/Source/platform/graphics/filters/FilterEffect.h
+++ b/Source/platform/graphics/filters/FilterEffect.h
@@ -37,8 +37,6 @@
#include "wtf/Uint8ClampedArray.h"
#include "wtf/Vector.h"
-static const float kMaxFilterSize = 5000.0f;
-
namespace WebCore {
class Filter;
@@ -69,6 +67,10 @@ class PLATFORM_EXPORT FilterEffect : public RefCounted<FilterEffect> {
public:
virtual ~FilterEffect();
+ static bool isFilterSizeValid(IntRect);
+ static bool isFilterSizeValid(FloatRect);
+ static float maxFilterArea();
+
void clearResult();
void clearResultsRecursive();
@@ -178,8 +180,9 @@ public:
virtual bool affectsTransparentPixels() { return false; }
protected:
- FilterEffect(Filter*);
+ static const float kMaxFilterArea;
fs 2014/02/07 10:17:51 Nit: Any reason to have this in class scope? (I.e.
Stephen Chennney 2014/02/11 14:47:21 In platform graphics it is typical to put these in
+ FilterEffect(Filter*);
ImageBuffer* createImageBufferResult();
Uint8ClampedArray* createUnmultipliedImageResult();
Uint8ClampedArray* createPremultipliedImageResult();

Powered by Google App Engine
This is Rietveld 408576698