Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1509723004: do not suggest static methods from superclass - fixes #24258 (Closed)

Created:
5 years ago by danrubel
Modified:
5 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

do not suggest static methods from superclass - fixes #24258 R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/824a012d8ff8cca7bf1398a3af84481e6b9ccf14

Patch Set 1 #

Patch Set 2 : fix test #

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -12 lines) Patch
M pkg/analysis_server/lib/src/services/completion/dart/static_member_contributor.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M pkg/analysis_server/test/completion_test.dart View 1 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/static_member_contributor_test.dart View 5 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
5 years ago (2015-12-09 17:29:35 UTC) #2
scheglov
LGTM
5 years ago (2015-12-09 19:25:21 UTC) #3
danrubel
5 years ago (2015-12-09 19:37:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:30001) manually as
824a012d8ff8cca7bf1398a3af84481e6b9ccf14 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698