Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Side by Side Diff: pkg/analysis_server/test/completion_test.dart

Issue 1509723004: do not suggest static methods from superclass - fixes #24258 (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: merge Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library test.completion.support; 5 library test.completion.support;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 import 'dart:collection'; 8 import 'dart:collection';
9 9
10 import 'package:unittest/unittest.dart'; 10 import 'package:unittest/unittest.dart';
(...skipping 1877 matching lines...) Expand 10 before | Expand all | Expand 10 after
1888 static int FIELD_A; 1888 static int FIELD_A;
1889 static int methodA() {} 1889 static int methodA() {}
1890 } 1890 }
1891 class B extends A { 1891 class B extends A {
1892 static int FIELD_B; 1892 static int FIELD_B;
1893 static int methodB() {} 1893 static int methodB() {}
1894 } 1894 }
1895 main() { 1895 main() {
1896 B.!1; 1896 B.!1;
1897 }''', 1897 }''',
1898 <String>["1+FIELD_B", "1-FIELD_A", "1+methodB", "1-methodA"], 1898 <String>["1+FIELD_B", "1-FIELD_A", "1+methodB", "1-methodA"]);
1899 failingTests: '1');
1900 1899
1901 buildTests( 1900 buildTests(
1902 'testCompletion_propertyAccess_whenInstanceTarget', 1901 'testCompletion_propertyAccess_whenInstanceTarget',
1903 ''' 1902 '''
1904 class A { 1903 class A {
1905 static int FIELD; 1904 static int FIELD;
1906 int fieldA; 1905 int fieldA;
1907 } 1906 }
1908 class B { 1907 class B {
1909 A a; 1908 A a;
(...skipping 1081 matching lines...) Expand 10 before | Expand all | Expand 10 after
2991 } else { 2990 } else {
2992 ++expectedPassCount; 2991 ++expectedPassCount;
2993 tester(testName, () { 2992 tester(testName, () {
2994 CompletionTestCase test = new CompletionTestCase(); 2993 CompletionTestCase test = new CompletionTestCase();
2995 return test.runTest(spec, extraFiles); 2994 return test.runTest(spec, extraFiles);
2996 }); 2995 });
2997 } 2996 }
2998 } 2997 }
2999 } 2998 }
3000 } 2999 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698