Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1509723003: Remove dependency on webrtc::SharedMemory::handle() (Closed)

Created:
5 years ago by Sergey Ulanov
Modified:
5 years ago
Reviewers:
erikchen, Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove_quic
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dependency on webrtc::SharedMemory::handle() webrtc::SharedMemory::handle() is never useful, so it will need to be removed. This changed removes dependency on that field so it can be removed later. Committed: https://crrev.com/d3719e0d139b0d6adbde4bdbbe1c459a6f0eba01 Cr-Commit-Position: refs/heads/master@{#363934}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -25 lines) Patch
M remoting/host/desktop_session_agent.cc View 2 chunks +8 lines, -13 lines 0 comments Download
M remoting/host/desktop_session_proxy.cc View 2 chunks +2 lines, -12 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (5 generated)
Sergey Ulanov
5 years ago (2015-12-08 17:48:37 UTC) #2
Jamie
lgtm
5 years ago (2015-12-08 18:37:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1509723003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1509723003/1
5 years ago (2015-12-08 19:24:16 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/152028)
5 years ago (2015-12-08 19:37:28 UTC) #7
erikchen
On 2015/12/08 19:37:28, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years ago (2015-12-08 23:58:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1509723003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1509723003/1
5 years ago (2015-12-08 23:59:34 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-09 02:32:22 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-09 02:34:00 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d3719e0d139b0d6adbde4bdbbe1c459a6f0eba01
Cr-Commit-Position: refs/heads/master@{#363934}

Powered by Google App Engine
This is Rietveld 408576698