Remoting: Remove references to POSIX shared memory.

Remoting: Remove references to POSIX shared memory.

https://codereview.chromium.org/1509723003/ removed all dependencies on the
implementation of shared memory. This CL removes the remaining references.

BUG=547247
Committed: https://crrev.com/9e1ffaa2e70f528ac6f879d5074954c1a4b96cb5
Cr-Commit-Position: refs/heads/master@{#367117}

[erikchen, 2015-12-09 02:17:09]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-09 02:21:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1509063003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1509063003/1

[commit-bot: I haz the power, 2015-12-09 02:39:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-09 02:39:01]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[erikchen, 2015-12-09 22:32:07]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-09 22:35:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1509063003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1509063003/20001

[commit-bot: I haz the power, 2015-12-09 23:09:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-09 23:09:21]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[erikchen, 2015-12-09 23:26:08]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-09 23:28:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1509063003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1509063003/40001

[commit-bot: I haz the power, 2015-12-10 00:57:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-10 00:57:55]

Dry run: This issue passed the CQ dry run.

[erikchen, 2015-12-10 01:01:17]

erikchen@chromium.org changed reviewers:
+ sergeyu@chromium.org, tsepez@chromium.org

[erikchen, 2015-12-10 01:01:18]

tsepez: Please review ipc/
sergeyu: Please review remoting/

[Tom Sepez, 2015-12-10 01:08:18]

lgtm

[Sergey Ulanov, 2015-12-12 06:41:34]

https://codereview.chromium.org/1509063003/diff/40001/remoting/host/remoting_...
File remoting/host/remoting_me2me_host.cc (right):

https://codereview.chromium.org/1509063003/diff/40001/remoting/host/remoting_...
remoting/host/remoting_me2me_host.cc:319:
scoped_ptr<IPC::AttachmentBrokerUnprivileged> attachment_broker_;
Why do we need attachment broker now, but didn't need it before?

https://codereview.chromium.org/1509063003/diff/40001/remoting/host/remoting_...
remoting/host/remoting_me2me_host.cc:412: .release()),
don't need release() here

https://codereview.chromium.org/1509063003/diff/40001/remoting/host/remoting_...
remoting/host/remoting_me2me_host.cc:479:
attachment_broker_->DesignateBrokerCommunicationChannel(
Comments for IPC::AttachmentBrokerUnprivileged::CreateBroker() say that it may
return nullptr, so you attachment_broker_ may be nullptr here

[erikchen, 2015-12-18 19:14:10]

sergeyu: PTAL

https://codereview.chromium.org/1509063003/diff/40001/remoting/host/remoting_...
File remoting/host/remoting_me2me_host.cc (right):

https://codereview.chromium.org/1509063003/diff/40001/remoting/host/remoting_...
remoting/host/remoting_me2me_host.cc:319:
scoped_ptr<IPC::AttachmentBrokerUnprivileged> attachment_broker_;
On 2015/12/12 06:41:33, Sergey Ulanov wrote:
> Why do we need attachment broker now, but didn't need it before?

An attachment broker is needed in each process that wants to send/receive mach
shared memory.

https://codereview.chromium.org/1509063003/diff/40001/remoting/host/remoting_...
remoting/host/remoting_me2me_host.cc:412: .release()),
On 2015/12/12 06:41:33, Sergey Ulanov wrote:
> don't need release() here

Done.

https://codereview.chromium.org/1509063003/diff/40001/remoting/host/remoting_...
remoting/host/remoting_me2me_host.cc:479:
attachment_broker_->DesignateBrokerCommunicationChannel(
On 2015/12/12 06:41:33, Sergey Ulanov wrote:
> Comments for IPC::AttachmentBrokerUnprivileged::CreateBroker() say that it may
> return nullptr, so you attachment_broker_ may be nullptr here

good point. Added a conditional.

[Sergey Ulanov, 2015-12-24 06:44:03]

lgtm

[erikchen, 2015-12-28 16:28:50]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2015-12-28 16:28:50]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/1509063003/#ps60001
(title: "Rebase + comments from sergeyu.")

[commit-bot: I haz the power, 2015-12-28 16:29:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1509063003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1509063003/60001

[commit-bot: I haz the power, 2015-12-28 16:30:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-28 16:30:33]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[erikchen, 2015-12-29 22:38:05]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2015-12-29 22:38:05]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
sergeyu@chromium.org
Link to the patchset: https://codereview.chromium.org/1509063003/#ps80001
(title: "Rebase.")

[commit-bot: I haz the power, 2015-12-29 22:38:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1509063003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1509063003/80001

[commit-bot: I haz the power, 2015-12-29 23:42:28]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-12-29 23:43:38]

Description was changed from

==========
Remoting: Remove references to POSIX shared memory.

https://codereview.chromium.org/1509723003/ removed all dependencies on the
implementation of shared memory. This CL removes the remaining references.

BUG=547247
==========

to

==========
Remoting: Remove references to POSIX shared memory.

https://codereview.chromium.org/1509723003/ removed all dependencies on the
implementation of shared memory. This CL removes the remaining references.

BUG=547247

Committed: https://crrev.com/9e1ffaa2e70f528ac6f879d5074954c1a4b96cb5
Cr-Commit-Position: refs/heads/master@{#367117}
==========

[commit-bot: I haz the power, 2015-12-29 23:43:39]

Patchset 5 (id:??) landed as
https://crrev.com/9e1ffaa2e70f528ac6f879d5074954c1a4b96cb5
Cr-Commit-Position: refs/heads/master@{#367117}