Enable Autocomplete feature for chromium webview

components/autofill/browser/autofill_manager.h

Index: components/autofill/browser/autofill_manager.h
diff --git a/components/autofill/browser/autofill_manager.h b/components/autofill/browser/autofill_manager.h
index d164923c8e55a68e89ceec4297020cdad2b7bb89..89799470b807be3d06f5c8641e16ce5ee8df28e1 100644
--- a/components/autofill/browser/autofill_manager.h
+++ b/components/autofill/browser/autofill_manager.h
@@ -210,7 +210,7 @@ class AutofillManager : public content::WebContentsObserver,
   }
 
   // Processes the submitted |form|, saving any new Autofill data and uploading
-  // the possible field types for the submitted fields to the crowdsouring
+  // the possible field types for the submitted fields to the crowdsourcing
   // server.  Returns false if this form is not relevant for Autofill.
   bool OnFormSubmitted(const FormData& form,
                        const base::TimeTicks& timestamp);
@@ -234,6 +234,7 @@ class AutofillManager : public content::WebContentsObserver,
   void OnFormsSeen(const std::vector<FormData>& forms,
                    const base::TimeTicks& timestamp,
                    autofill::FormsSeenState state);
+
   void OnTextFieldDidChange(const FormData& form,
                             const FormFieldData& field,
                             const base::TimeTicks& timestamp);
@@ -244,6 +245,16 @@ class AutofillManager : public content::WebContentsObserver,
                                 const FormFieldData& field,
                                 const gfx::RectF& bounding_box,
                                 bool display_warning);
+
+  // Receive autofillsuggestions from |personal_data_|.
+  void GetAutofillSuggestions(
+      const FormData& form,
+      const FormFieldData& field,
+      std::vector<base::string16>* values,
+      std::vector<base::string16>* labels,
+      std::vector<string16>* icons,
+      std::vector<int>* unique_ids);
+
   void OnDidEndTextFieldEditing();
   void OnHideAutofillUi();
   void OnAddPasswordFormMapping(
@@ -350,7 +361,7 @@ class AutofillManager : public content::WebContentsObserver,
   // The personal data manager, used to save and load personal data to/from the
   // web database.  This is overridden by the AutofillManagerTest.
   // Weak reference.
-  // May be NULL.  NULL indicates OTR.
+  // May be NULL for OTR and Android Webview.

[Ilya Sherman, 2013/06/15 00:28:09]

I don't think it's true that personal_data_ is null in Incognito mode, as we
still offer Autofill suggestions in Incognito mode.

[sgurun-gerrit only, 2013/06/17 21:20:32]

himm, perhaps the comment is not true anymore then. I will verify.

On 2013/06/15 00:28:09, Ilya Sherman wrote:

   PersonalDataManager* personal_data_;
 
   std::list<std::string> autofilled_form_signatures_;
@@ -362,7 +373,7 @@ class AutofillManager : public content::WebContentsObserver,
   // Handles single-field autocomplete form data.
   AutocompleteHistoryManager autocomplete_history_manager_;
 
-  // Handles autocheckout flows.
+  // Handles autocheckout flows. NULL for Android Webview.

[Ilya Sherman, 2013/06/15 00:28:09]

What does it mean for this non-pointer value to be NULL?

[sgurun-gerrit only, 2013/06/17 21:20:32]

yeah. this is a runaway leftover comment. I was thinking of making this a
pointer since it does not apply to android webview, but then decided not to mess
with it.
On 2013/06/15 00:28:09, Ilya Sherman wrote:

   autofill::AutocheckoutManager autocheckout_manager_;
 
   // For logging UMA metrics. Overridden by metrics tests.