Enable Autocomplete feature for chromium webview

components/autofill/browser/autofill_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_BROWSER_AUTOFILL_MANAGER_H_
 #define COMPONENTS_AUTOFILL_BROWSER_AUTOFILL_MANAGER_H_
 
 #include <list>
 #include <map>
 #include <string>
@@ skipping 139 matching lines @@
                   autofill::AutofillManagerDelegate* delegate,
                   const std::string& app_locale,
                   AutofillDownloadManagerState enable_download_manager);
   virtual ~AutofillManager();
 
   // Test code should prefer to use this constructor.
   AutofillManager(content::WebContents* web_contents,
                   autofill::AutofillManagerDelegate* delegate,
                   PersonalDataManager* personal_data);
 
   // Returns the value of the AutofillEnabled pref.

[Ilya Sherman, 2013/06/15 00:28:09]

Please update this comment.

[sgurun-gerrit only, 2013/06/17 21:20:32]

Done.

   virtual bool IsAutofillEnabled() const;
 
   // Uploads the form data to the Autofill server.
   virtual void UploadFormData(const FormStructure& submitted_form);
 
   // Reset cache.
   void Reset();
 
   // Logs quality metrics for the |submitted_form| and uploads the form data
   // to the crowdsourcing server, if appropriate.
@@ skipping 32 matching lines @@
   AutofillExternalDelegate* external_delegate() {
     return external_delegate_;
   }
 
   // Exposed for testing.
   autofill::AutocheckoutManager* autocheckout_manager() {
     return &autocheckout_manager_;
   }
 
   // Processes the submitted |form|, saving any new Autofill data and uploading
-  // the possible field types for the submitted fields to the crowdsouring
+  // the possible field types for the submitted fields to the crowdsourcing
   // server.  Returns false if this form is not relevant for Autofill.
   bool OnFormSubmitted(const FormData& form,
                        const base::TimeTicks& timestamp);
 
   // Tell the renderer the current interactive autocomplete finished.
   virtual void ReturnAutocompleteResult(
       WebKit::WebFormElement::AutocompleteResult result,
       const FormData& form_data);
 
  private:
   // content::WebContentsObserver:
   virtual void DidNavigateMainFrame(
       const content::LoadCommittedDetails& details,
       const content::FrameNavigateParams& params) OVERRIDE;
   virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
 
   // AutofillDownloadManager::Observer:
   virtual void OnLoadedServerPredictions(
       const std::string& response_xml) OVERRIDE;
 
   void OnFormsSeen(const std::vector<FormData>& forms,
                    const base::TimeTicks& timestamp,
                    autofill::FormsSeenState state);
+
   void OnTextFieldDidChange(const FormData& form,
                             const FormFieldData& field,
                             const base::TimeTicks& timestamp);
 
   // The |bounding_box| is a window relative value.
   void OnQueryFormFieldAutofill(int query_id,
                                 const FormData& form,
                                 const FormFieldData& field,
                                 const gfx::RectF& bounding_box,
                                 bool display_warning);
+
+  // Receive autofillsuggestions from |personal_data_|.
+  void GetAutofillSuggestions(
+      const FormData& form,
+      const FormFieldData& field,
+      std::vector<base::string16>* values,
+      std::vector<base::string16>* labels,
+      std::vector<string16>* icons,
+      std::vector<int>* unique_ids);
+
   void OnDidEndTextFieldEditing();
   void OnHideAutofillUi();
   void OnAddPasswordFormMapping(
       const FormFieldData& form,
       const PasswordFormFillData& fill_data);
   void OnShowPasswordSuggestions(
       const FormFieldData& field,
       const gfx::RectF& bounds,
       const std::vector<base::string16>& suggestions);
   void OnSetDataList(const std::vector<base::string16>& values,
@@ skipping 86 matching lines @@
   void SendAutofillTypePredictions(
       const std::vector<FormStructure*>& forms) const;
 
   autofill::AutofillManagerDelegate* const manager_delegate_;
 
   std::string app_locale_;
 
   // The personal data manager, used to save and load personal data to/from the
   // web database.  This is overridden by the AutofillManagerTest.
   // Weak reference.
-  // May be NULL.  NULL indicates OTR.
+  // May be NULL for OTR and Android Webview.

[Ilya Sherman, 2013/06/15 00:28:09]

I don't think it's true that personal_data_ is null in Incognito mode, as we
still offer Autofill suggestions in Incognito mode.

[sgurun-gerrit only, 2013/06/17 21:20:32]

himm, perhaps the comment is not true anymore then. I will verify.

On 2013/06/15 00:28:09, Ilya Sherman wrote:

   PersonalDataManager* personal_data_;
 
   std::list<std::string> autofilled_form_signatures_;
 
   // Handles queries and uploads to Autofill servers. Will be NULL if
   // the download manager functionality is disabled.
   scoped_ptr<AutofillDownloadManager> download_manager_;
 
   // Handles single-field autocomplete form data.
   AutocompleteHistoryManager autocomplete_history_manager_;
 
-  // Handles autocheckout flows.
+  // Handles autocheckout flows. NULL for Android Webview.

[Ilya Sherman, 2013/06/15 00:28:09]

What does it mean for this non-pointer value to be NULL?

[sgurun-gerrit only, 2013/06/17 21:20:32]

yeah. this is a runaway leftover comment. I was thinking of making this a
pointer since it does not apply to android webview, but then decided not to mess
with it.
On 2013/06/15 00:28:09, Ilya Sherman wrote:

   autofill::AutocheckoutManager autocheckout_manager_;
 
   // For logging UMA metrics. Overridden by metrics tests.
   scoped_ptr<const AutofillMetrics> metric_logger_;
   // Have we logged whether Autofill is enabled for this page load?
   bool has_logged_autofill_enabled_;
   // Have we logged an address suggestions count metric for this page?
   bool has_logged_address_suggestions_count_;
   // Have we shown Autofill suggestions at least once?
   bool did_show_suggestions_;
@@ skipping 50 matching lines @@
   FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest,
                            UserHappinessFormLoadAndSubmission);
   FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, UserHappinessFormInteraction);
 
   DISALLOW_COPY_AND_ASSIGN(AutofillManager);
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_BROWSER_AUTOFILL_MANAGER_H_