Enable Autocomplete feature for chromium webview

components/autofill/browser/autofill_manager.h

Index: components/autofill/browser/autofill_manager.h
diff --git a/components/autofill/browser/autofill_manager.h b/components/autofill/browser/autofill_manager.h
index 9233659024069dc5f392bf3d0957a0ea438acc4a..cf4593288c4c4bd0bc487c0599a4b8284224792c 100644
--- a/components/autofill/browser/autofill_manager.h
+++ b/components/autofill/browser/autofill_manager.h
@@ -203,7 +203,7 @@ class AutofillManager : public content::WebContentsObserver,
   }
 
   // Processes the submitted |form|, saving any new Autofill data and uploading
-  // the possible field types for the submitted fields to the crowdsouring
+  // the possible field types for the submitted fields to the crowdsourcing
   // server.  Returns false if this form is not relevant for Autofill.
   bool OnFormSubmitted(const FormData& form,
                        const base::TimeTicks& timestamp);
@@ -237,6 +237,15 @@ class AutofillManager : public content::WebContentsObserver,
                                 const FormFieldData& field,
                                 const gfx::RectF& bounding_box,
                                 bool display_warning);

[Ilya Sherman, 2013/06/03 23:22:19]

nit: Add a newline after this line.

[sgurun-gerrit only, 2013/06/13 01:13:31]

Done.

+  void OnQueryFormFieldAutofillPersonalData(

[Ilya Sherman, 2013/06/03 23:22:19]

Please name this method something more like "GetAutofillSuggestions()", and add
documentation.

[sgurun-gerrit only, 2013/06/13 01:13:31]

Done.

+      int query_id,
+      const FormData& form,
+      const FormFieldData& field,
+      std::vector<base::string16>* values,
+      std::vector<base::string16>* labels,
+      std::vector<string16>* icons,
+      std::vector<int>* unique_ids);
+
   void OnDidEndTextFieldEditing();
   void OnHideAutofillUi();
   void OnAddPasswordFormMapping(
@@ -351,7 +360,7 @@ class AutofillManager : public content::WebContentsObserver,
   // The personal data manager, used to save and load personal data to/from the
   // web database.  This is overridden by the AutofillManagerTest.
   // Weak reference.
-  // May be NULL.  NULL indicates OTR.
+  // May be NULL for OTR and android webview.

[Ilya Sherman, 2013/06/03 23:22:19]

nit: "Android WebView".  Ditto below.

[sgurun-gerrit only, 2013/06/13 01:13:31]

Done.

   PersonalDataManager* personal_data_;
 
   std::list<std::string> autofilled_form_signatures_;
@@ -363,7 +372,7 @@ class AutofillManager : public content::WebContentsObserver,
   // Handles single-field autocomplete form data.
   AutocompleteHistoryManager autocomplete_history_manager_;
 
-  // Handles autocheckout flows.
+  // Handles autocheckout flows. NULL for android webview.
   autofill::AutocheckoutManager autocheckout_manager_;
 
   // For logging UMA metrics. Overridden by metrics tests.