Enable Autocomplete feature for chromium webview

components/autofill/browser/autofill_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_BROWSER_AUTOFILL_MANAGER_H_
 #define COMPONENTS_AUTOFILL_BROWSER_AUTOFILL_MANAGER_H_
 
 #include <list>
 #include <map>
 #include <string>
@@ skipping 185 matching lines @@
   AutofillExternalDelegate* external_delegate() {
     return external_delegate_;
   }
 
   // Exposed for testing.
   autofill::AutocheckoutManager* autocheckout_manager() {
     return &autocheckout_manager_;
   }
 
   // Processes the submitted |form|, saving any new Autofill data and uploading
-  // the possible field types for the submitted fields to the crowdsouring
+  // the possible field types for the submitted fields to the crowdsourcing
   // server.  Returns false if this form is not relevant for Autofill.
   bool OnFormSubmitted(const FormData& form,
                        const base::TimeTicks& timestamp);
 
   // Tell the renderer the current interactive autocomplete finished.
   virtual void ReturnAutocompleteResult(
       WebKit::WebFormElement::AutocompleteResult result,
       const FormData& form_data);
 
  private:
@@ skipping 12 matching lines @@
                    autofill::FormsSeenState state);
   void OnTextFieldDidChange(const FormData& form,
                             const FormFieldData& field,
                             const base::TimeTicks& timestamp);
 
   // The |bounding_box| is a window relative value.
   void OnQueryFormFieldAutofill(int query_id,
                                 const FormData& form,
                                 const FormFieldData& field,
                                 const gfx::RectF& bounding_box,
                                 bool display_warning);

[Ilya Sherman, 2013/06/03 23:22:19]

nit: Add a newline after this line.

[sgurun-gerrit only, 2013/06/13 01:13:31]

Done.

+  void OnQueryFormFieldAutofillPersonalData(

[Ilya Sherman, 2013/06/03 23:22:19]

Please name this method something more like "GetAutofillSuggestions()", and add
documentation.

[sgurun-gerrit only, 2013/06/13 01:13:31]

Done.

+      int query_id,
+      const FormData& form,
+      const FormFieldData& field,
+      std::vector<base::string16>* values,
+      std::vector<base::string16>* labels,
+      std::vector<string16>* icons,
+      std::vector<int>* unique_ids);
+
   void OnDidEndTextFieldEditing();
   void OnHideAutofillUi();
   void OnAddPasswordFormMapping(
       const FormFieldData& form,
       const PasswordFormFillData& fill_data);
   void OnShowPasswordSuggestions(
       const FormFieldData& field,
       const gfx::RectF& bounds,
       const std::vector<base::string16>& suggestions);
   void OnSetDataList(const std::vector<base::string16>& values,
@@ skipping 94 matching lines @@
   void SendAutofillTypePredictions(
       const std::vector<FormStructure*>& forms) const;
 
   autofill::AutofillManagerDelegate* const manager_delegate_;
 
   std::string app_locale_;
 
   // The personal data manager, used to save and load personal data to/from the
   // web database.  This is overridden by the AutofillManagerTest.
   // Weak reference.
-  // May be NULL.  NULL indicates OTR.
+  // May be NULL for OTR and android webview.

[Ilya Sherman, 2013/06/03 23:22:19]

nit: "Android WebView".  Ditto below.

[sgurun-gerrit only, 2013/06/13 01:13:31]

Done.

   PersonalDataManager* personal_data_;
 
   std::list<std::string> autofilled_form_signatures_;
 
   // Handles queries and uploads to Autofill servers. Will be NULL if
   // the download manager functionality is disabled.
   scoped_ptr<AutofillDownloadManager> download_manager_;
 
   // Handles single-field autocomplete form data.
   AutocompleteHistoryManager autocomplete_history_manager_;
 
-  // Handles autocheckout flows.
+  // Handles autocheckout flows. NULL for android webview.
   autofill::AutocheckoutManager autocheckout_manager_;
 
   // For logging UMA metrics. Overridden by metrics tests.
   scoped_ptr<const AutofillMetrics> metric_logger_;
   // Have we logged whether Autofill is enabled for this page load?
   bool has_logged_autofill_enabled_;
   // Have we logged an address suggestions count metric for this page?
   bool has_logged_address_suggestions_count_;
   // Have we shown Autofill suggestions at least once?
   bool did_show_suggestions_;
@@ skipping 50 matching lines @@
   FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest,
                            UserHappinessFormLoadAndSubmission);
   FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, UserHappinessFormInteraction);
 
   DISALLOW_COPY_AND_ASSIGN(AutofillManager);
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_BROWSER_AUTOFILL_MANAGER_H_