components/autofill/browser/autocomplete_history_manager.cc - Issue 15097004: Enable Autocomplete feature for chromium webview

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/browser/autocomplete_history_manager.cc

Issue 15097004: Enable Autocomplete feature for chromium webview (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@setSaveFormData2

Patch Set: make personal_data_ optional Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/renderer/aw_content_renderer_client.cc ('K') | « android_webview/renderer/aw_content_renderer_client.cc ('k') | components/autofill/browser/autofill_external_delegate.h » ('j') | components/autofill/browser/autofill_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/browser/autocomplete_history_manager.cc

diff --git a/components/autofill/browser/autocomplete_history_manager.cc b/components/autofill/browser/autocomplete_history_manager.cc

index 5d982949f0b15c2c4c22926d35358cec3b572fa9..3a5514501dd6392cc7d0cf309c09165cc4bbb652 100644

--- a/components/autofill/browser/autocomplete_history_manager.cc

+++ b/components/autofill/browser/autocomplete_history_manager.cc

@@ -127,7 +127,7 @@ void AutocompleteHistoryManager::OnFormSubmitted(const FormData& form) {

if (!*autofill_enabled_)

return;

- if (browser_context_->IsOffTheRecord())

+ if (external_delegate_ && external_delegate_->ShouldIgnoreFormData())

benm (inactive) 2013/05/23 12:02:21 In what situation is external_delegate_ not instal

sgurun-gerrit only 2013/05/23 17:10:01 This is a fair point. I did a code search and foun

return;

// Don't save data that was submitted through JavaScript.