Enable Autocomplete feature for chromium webview

components/autofill/browser/autocomplete_history_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/browser/autocomplete_history_manager.h"
 
 #include <vector>
 
 #include "base/prefs/pref_service.h"
 #include "base/string16.h"
@@ skipping 109 matching lines @@
   if (autofill_data_.get()) {
     pending_query_handle_ = autofill_data_->GetFormValuesForElementName(
         name, prefix, kMaxAutocompleteMenuItems, this);
   }
 }
 
 void AutocompleteHistoryManager::OnFormSubmitted(const FormData& form) {
   if (!*autofill_enabled_)
     return;
 
-  if (browser_context_->IsOffTheRecord())
+  if (external_delegate_ && external_delegate_->ShouldIgnoreFormData())

[benm (inactive), 2013/05/23 12:02:21]

In what situation is external_delegate_ not installed? Seems like this could be
a behavior change for clients that do not set it.

[sgurun-gerrit only, 2013/05/23 17:10:01]

This is a fair point. I did a code search and found that it is always installed.
I would love to hear what autofill folks have to say about it.

On 2013/05/23 12:02:21, benm wrote:

     return;
 
   // Don't save data that was submitted through JavaScript.
   if (!form.user_submitted)
     return;
 
   // We put the following restriction on stored FormFields:
   //  - non-empty name
   //  - non-empty value
   //  - text field
@@ skipping 75 matching lines @@
   }
 
   query_id_ = 0;
   autofill_values_.clear();
   autofill_labels_.clear();
   autofill_icons_.clear();
   autofill_unique_ids_.clear();
 }
 
 }  // namespace autofill