Source/core/scripts/templates/InternalRuntimeFlags.idl.tmpl - Issue 15095002: Use jinja2 for make_runtime_features and make_internal_runtime_flags

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/scripts/templates/InternalRuntimeFlags.idl.tmpl

Issue 15095002: Use jinja2 for make_runtime_features and make_internal_runtime_flags (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master

Patch Set: Updated for Eric's suggestions Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/scripts/templates/InternalRuntimeFlags.h.tmpl ('k') | Source/core/scripts/templates/RuntimeEnabledFeatures.cpp.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/scripts/templates/InternalRuntimeFlags.idl.tmpl

diff --git a/Source/core/scripts/templates/InternalRuntimeFlags.idl.tmpl b/Source/core/scripts/templates/InternalRuntimeFlags.idl.tmpl

new file mode 100644

index 0000000000000000000000000000000000000000..31a4bfd981b77a41572709c14717b19550815809

--- /dev/null

+++ b/Source/core/scripts/templates/InternalRuntimeFlags.idl.tmpl

@@ -0,0 +1,16 @@

+{% from "macros.tmpl" import license -%}

+{{ license() }}

+ ImplementationLacksVTable

+] interface InternalRuntimeFlags {

+{%- for feature in features if not feature.custom %}

+{#-

+ Currently assuming that runtime flags cannot be changed after startup

+ it's possible that some can be and should be conditionally readonly.

+#}

+ {% if feature.condition -%} [Conditional={{feature.condition}}] {% endif -%}

+ readonly attribute boolean {{feature.first_lowered_name}}Enabled;

+{%- endfor %}

+};