Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 15095002: Use jinja2 for make_runtime_features and make_internal_runtime_flags (Closed)

Created:
7 years, 7 months ago by Timothy Loh
Modified:
7 years, 7 months ago
CC:
blink-reviews, eae+blinkwatch, eseidel, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink@master
Visibility:
Public.

Description

Use jinja2 for make_runtime_features and make_internal_runtime_flags Begin moving python code generators to jinja2. Some previous discussion on https://codereview.chromium.org/14905002/. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150285

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated for Adam's comments #

Total comments: 3

Patch Set 3 : Updated for Eric's suggestions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -190 lines) Patch
M Source/core/core.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/core.gyp/core_derived_sources.gyp View 2 chunks +4 lines, -0 lines 0 comments Download
M Source/core/scripts/in_generator.py View 1 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/scripts/make_internal_runtime_flags.py View 1 1 chunk +5 lines, -66 lines 0 comments Download
M Source/core/scripts/make_runtime_features.py View 1 4 chunks +10 lines, -93 lines 0 comments Download
A + Source/core/scripts/template_expander.py View 1 2 2 chunks +12 lines, -14 lines 0 comments Download
A Source/core/scripts/templates/InternalRuntimeFlags.h.tmpl View 1 1 chunk +40 lines, -0 lines 0 comments Download
A Source/core/scripts/templates/InternalRuntimeFlags.idl.tmpl View 1 1 chunk +16 lines, -0 lines 0 comments Download
A Source/core/scripts/templates/RuntimeEnabledFeatures.cpp.tmpl View 1 1 chunk +25 lines, -0 lines 0 comments Download
A Source/core/scripts/templates/RuntimeEnabledFeatures.h.tmpl View 1 1 chunk +48 lines, -0 lines 0 comments Download
A + Source/core/scripts/templates/macros.tmpl View 1 2 chunks +15 lines, -17 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Timothy Loh
Hi guys, Now that jinja2 is in chromium's third_party, I'm starting to move over the ...
7 years, 7 months ago (2013-05-10 07:50:19 UTC) #1
abarth-chromium
Looks cool! I'll let Eric give the official stamp. https://codereview.chromium.org/15095002/diff/1/Source/core/scripts/template_expander.py File Source/core/scripts/template_expander.py (right): https://codereview.chromium.org/15095002/diff/1/Source/core/scripts/template_expander.py#newcode37 Source/core/scripts/template_expander.py:37: ...
7 years, 7 months ago (2013-05-10 16:18:40 UTC) #2
Timothy Loh
On 2013/05/10 16:18:40, abarth wrote: > applytemplate -> apply_template > pathtotemplate -> path_to_template Fixed > ...
7 years, 7 months ago (2013-05-13 03:13:08 UTC) #3
eseidel
This looks OK. I'm sure we'll iterate more. the generate_header thing is confusing to me ...
7 years, 7 months ago (2013-05-13 06:38:33 UTC) #4
Timothy Loh
On 2013/05/13 06:38:33, Eric Seidel wrote: > This looks OK. I'm sure we'll iterate more. ...
7 years, 7 months ago (2013-05-13 06:55:00 UTC) #5
eseidel
On Sun, May 12, 2013 at 11:55 PM, <timloh@chromium.org> wrote: > On 2013/05/13 06:38:33, Eric ...
7 years, 7 months ago (2013-05-13 07:01:11 UTC) #6
Timothy Loh
On 2013/05/13 07:01:11, Eric Seidel wrote: > No, it's fine that we use the same ...
7 years, 7 months ago (2013-05-13 07:16:19 UTC) #7
Timothy Loh
Okay perhaps we'll leave this patch as it is at the moment and then iterate ...
7 years, 7 months ago (2013-05-13 08:16:01 UTC) #8
eseidel
lgtm Thanks! Tim says he plans to iterate further on these. I'm a big fan ...
7 years, 7 months ago (2013-05-14 00:24:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/15095002/20001
7 years, 7 months ago (2013-05-14 00:24:46 UTC) #10
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=7774
7 years, 7 months ago (2013-05-14 01:07:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/15095002/20001
7 years, 7 months ago (2013-05-14 01:15:01 UTC) #12
commit-bot: I haz the power
7 years, 7 months ago (2013-05-14 03:16:33 UTC) #13
Message was sent while issue was closed.
Change committed as 150285

Powered by Google App Engine
This is Rietveld 408576698