Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 15094006: Change gpu blacklists from json resource to const string. (Closed)

Created:
7 years, 7 months ago by Zhenyao Mo
Modified:
7 years, 7 months ago
CC:
chromium-reviews, craigdh+watch_chromium.org, jam, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, bulach+watch_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Change gpu blacklists from json resource to const string. Since we no longer do realtime blacklist update, so the need to keep it as a independent json file is no longer there. BUG= TEST=content_unitests R=apatrick@chromium.org, piman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200315

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -1641 lines) Patch
M build/android/pylib/gtest/test_runner.py View 1 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/gpu/gpu_blacklist_unittest.cc View 1 2 chunks +3 lines, -20 lines 0 comments Download
A content/browser/gpu/gpu_control_list_jsons.h View 1 chunk +19 lines, -0 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl_private.cc View 1 3 chunks +4 lines, -14 lines 0 comments Download
D content/browser/gpu/gpu_driver_bug_list.json View 1 1 chunk +0 lines, -336 lines 0 comments Download
A + content/browser/gpu/gpu_driver_bug_list_json.cc View 3 chunks +17 lines, -0 lines 0 comments Download
M content/browser/gpu/gpu_driver_bug_list_unittest.cc View 1 4 chunks +4 lines, -36 lines 0 comments Download
D content/browser/gpu/gpu_switching_list.json View 1 1 chunk +0 lines, -107 lines 0 comments Download
A + content/browser/gpu/gpu_switching_list_json.cc View 3 chunks +17 lines, -0 lines 0 comments Download
M content/browser/gpu/gpu_switching_list_unittest.cc View 1 2 chunks +3 lines, -20 lines 0 comments Download
D content/browser/gpu/software_rendering_list.json View 1 1 chunk +0 lines, -1099 lines 0 comments Download
A + content/browser/gpu/software_rendering_list_json.cc View 3 chunks +17 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 1 2 chunks +4 lines, -0 lines 0 comments Download
M content/content_resources.grd View 1 1 chunk +0 lines, -3 lines 0 comments Download
M content/content_unittests.isolate View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Zhenyao Mo
Al, can you review this CL?
7 years, 7 months ago (2013-05-10 21:00:45 UTC) #1
apatrick_chromium
lgtm
7 years, 7 months ago (2013-05-10 22:15:37 UTC) #2
Zhenyao Mo
piman: content/ owner review.
7 years, 7 months ago (2013-05-10 22:25:32 UTC) #3
piman
I support the change, but could we keep the files as json and #include them ...
7 years, 7 months ago (2013-05-10 23:18:39 UTC) #4
Zhenyao Mo
On 2013/05/10 23:18:39, piman wrote: > I support the change, but could we keep the ...
7 years, 7 months ago (2013-05-10 23:25:53 UTC) #5
piman
Mmh, yeah, it doesn't seem to work, so LGTM this.
7 years, 7 months ago (2013-05-11 01:56:22 UTC) #6
Zhenyao Mo
7 years, 7 months ago (2013-05-15 18:14:34 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r200315 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698